Attention is currently required from: Zheng Bao.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69856 )
Change subject: amdfwtool: Allow the location to be a relative address ......................................................................
Patch Set 1:
(6 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164215): https://review.coreboot.org/c/coreboot/+/69856/comment/55308f6f_8b9968b5 PS1, Line 2365: case 0xFA0000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164215): https://review.coreboot.org/c/coreboot/+/69856/comment/16dcf20f_8a396c0c PS1, Line 2366: case 0xF20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164215): https://review.coreboot.org/c/coreboot/+/69856/comment/f0e751fc_12332c30 PS1, Line 2367: case 0xE20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164215): https://review.coreboot.org/c/coreboot/+/69856/comment/be29d6a9_8d6bdfb2 PS1, Line 2368: case 0xC20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164215): https://review.coreboot.org/c/coreboot/+/69856/comment/d940274b_636b51e7 PS1, Line 2369: case 0x820000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164215): https://review.coreboot.org/c/coreboot/+/69856/comment/90368186_764c7e6b PS1, Line 2370: case 0x020000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment