Attention is currently required from: Patrick Rudolph, Jonathan Zhang, Paul Menzel, Christian Walter, Nill Ge, TangYiwei, Shelly Chang.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69310 )
Change subject: drivers/ipmi: Retry ipmi_get_device_id in ipmi_kcs_init ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69310/comment/bd48cb50_26c04619 PS2, Line 7: src/
Please remove.
Done
https://review.coreboot.org/c/coreboot/+/69310/comment/569138ad_f43e5276 PS2, Line 8:
Please describe the problem in detail. […]
Done
https://review.coreboot.org/c/coreboot/+/69310/comment/e180edc4_124827da PS2, Line 11:
Please mention the solution (retrying up to ten times and waiting one second), and how you determine […]
The IPMI handshaking w/ BMC still relies on retry for certain IPMI commands, especially this command that would disable IPMI device if it failed. The 10 seconds retry time should be big enough and wait_ms would return early whenever the condition is satisfied, so only the worst case would take up to 10 seconds which is not supposed to happen from a SW perspective.
File src/drivers/ipmi/ipmi_kcs_ops.c:
https://review.coreboot.org/c/coreboot/+/69310/comment/641e07e6_c9f38b0e PS2, Line 130: }
Please use coreboot’s stopwatch framework. Maybe `wait_ms()` can be used.
Done
-
Johnny Lin (Code Review)