Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49929 )
Change subject: soc/amd/cezanne: Enable early LPC support in bootblock stage
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/cezanne/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/49929/comment/77a6354f_53020a26
PS2, Line 16: #define I2C_MASTER_DEV_COUNT 4
: #define I2C_MASTER_START_INDEX 2
: #define I2C_SLAVE_DEV_COUNT 1
:
: #define APU_I2C2_BASE 0xfedc4000
: #define APU_I2C3_BASE 0xfedc5000
: #define APU_I2C4_BASE 0xfedc6000
:
: /* I2C parameters for lpc_read_resources */
: #define I2C_BASE_ADDRESS APU_I2C2_BASE
: #define I2C_DEVICE_SIZE 0x00001000
: #define I2C_DEVICE_COUNT (I2C_MASTER_DEV_COUNT \
:
the i2c defines seem to be unrelated
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49929
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I739d97ddc5afd84a4bbc7e505b423158eb820767
Gerrit-Change-Number: 49929
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Tue, 26 Jan 2021 14:54:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment