Change in ...coreboot[master]: Documentation/../../icelake_rvp: Add RVP coreboot development documen...
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29828 )
Change subject: Documentation/../../icelake_rvp: Add RVP coreboot development documentation ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/29828/2/Documentation/mainboard/intel/icelak... File Documentation/mainboard/intel/icelake_rvp.md:
https://review.coreboot.org/#/c/29828/2/Documentation/mainboard/intel/icelak... PS2, Line 17:
I'm fine with that, but it's an extra step compared to these 3. To be honest, I disagree with the others that we need to explain this every. single. time.
Line 12 should be sufficient, as it explains the process: pick the board in Kconfig (by whatever means necessary), build, done. Maybe add "Following the instructions for Ice Lake, " before it so that the blobs thing is mentioned.
-
Patrick Georgi (Code Review)