Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27714 )
Change subject: security/vboot: Add failure safety configurations ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/#/c/27714/1/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/#/c/27714/1/src/security/vboot/Kconfig@53 PS1, Line 53: bool
Can you outline your bigger plan with these MAINBOARD_... and USER_... […]
Easy peasy.
1) Users can decide for a Slot layout if not set by the board. 2) Slot layouts can be set by the board. 3) I will write an fmapgen tool for generating fmaps dynamically by kconfig input.
https://review.coreboot.org/#/c/27714/1/src/security/vboot/Kconfig@54 PS1, Line 54:
nit: not sure I like calling this "safety", that seems a little far removed from what it actually co […]
Ack
https://review.coreboot.org/#/c/27714/1/src/security/vboot/Kconfig@57 PS1, Line 57:
nit: I would avoid using the name "recovery" here since it means something specific and different in […]
Ack
https://review.coreboot.org/#/c/27714/1/src/security/vboot/Kconfig@71 PS1, Line 71: config USER_VBOOT_SLOTS_A
Technically the "firmware" might consist of IFD and ME or other blobs, too. […]
Ack
-
Philipp Deppenwiese (Code Review)