Change in coreboot[master]: mediatek/mt8183: support get current DRAM type

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

huayang duan (Code Review)

19 Jul 2019 19 Jul '19

6:15 a.m.

huayang duan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

mediatek/mt8183: support get current DRAM type

read the ramid to get the DRAM type of current platform

BUG=b:80501386 BRANCH=none TEST=Memory test pass on EMCP platform

Change-Id: Icf875427347418f796cbf193070bf047844d2267 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/soc/mediatek/mt8183/emi.c M src/soc/mediatek/mt8183/include/soc/emi.h 2 files changed, 30 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/1

diff --git a/src/soc/mediatek/mt8183/emi.c b/src/soc/mediatek/mt8183/emi.c index 937d06d..084a7a3 100644 --- a/src/soc/mediatek/mt8183/emi.c +++ b/src/soc/mediatek/mt8183/emi.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */

+#include <boardid.h> #include <device/mmio.h> #include <soc/emi.h> #include <soc/infracfg.h> @@ -42,6 +43,30 @@ return read32(&mt8183_infracfg->dramc_wbr); }

+int get_dram_type(void) +{ + uint32_t ramcode = ram_code(); + uint32_t dram_type; + + switch (ramcode) { + case 0: + case 1: + case 2: + dram_type = DRAM_TYPE_DISCRETE; + break; + case 3: + case 4: + case 5: + case 6: + case 7: + default: + dram_type = DRAM_TYPE_EMCP; + break; + } + + return dram_type; +} + static u64 get_ch_rank_size(u8 chn, u8 rank) { u32 shift_for_16bit = 1; diff --git a/src/soc/mediatek/mt8183/include/soc/emi.h b/src/soc/mediatek/mt8183/include/soc/emi.h index 2c04a50..f075429 100644 --- a/src/soc/mediatek/mt8183/include/soc/emi.h +++ b/src/soc/mediatek/mt8183/include/soc/emi.h @@ -33,6 +33,10 @@ u16 delay_cell_unit; };

+enum { + DRAM_TYPE_DISCRETE, + DRAM_TYPE_EMCP, +}; extern const u8 phy_mapping[CHANNEL_MAX][16];

int complex_mem_test(u8 *start, unsigned int len); @@ -41,5 +45,6 @@ void enable_emi_dcm(void); void mt_set_emi(const struct sdram_params *params); void mt_mem_init(const struct sdram_params *params); +int get_dram_type(void);

#endif /* SOC_MEDIATEK_MT8183_EMI_H */

Attachments:

attachment.htm (text/html — 5.4 KB)

Show replies by date

build bot (Jenkins) (Code Review)

19 Jul 19 Jul

6:16 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/1/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:

https://review.coreboot.org/c/coreboot/+/34433/1/src/soc/mediatek/mt8183/emi... PS1, Line 51: switch (ramcode) { switch and case should be at the same indent

huayang duan (Code Review)

22 Jul 22 Jul

7:32 a.m.

Hello Julius Werner, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34433

to look at the new patch set (#2).

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

mediatek/mt8183: support get current DRAM type

read the ramid to get the DRAM type of current platform

BUG=b:80501386 BRANCH=none TEST=Memory test pass on EMCP platform

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/2

Hung-Te Lin (Code Review)

8:05 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/2/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:

https://review.coreboot.org/c/coreboot/+/34433/2/src/soc/mediatek/mt8183/emi... PS2, Line 46: int get_dram_type(void) : { : uint32_t ramcode = ram_code(); : uint32_t dram_type; : : switch (ramcode) { : case 0: : case 1: : case 2: : dram_type = DRAM_TYPE_DISCRETE; : break; : case 3: : case 4: : case 5: : case 6: : case 7: : default: : dram_type = DRAM_TYPE_EMCP; : break; : } : : return dram_type; : } this is a board-specific thing and we should not put that in soc folder.

Please consider moving the type info to src/mainboard/google/kukui/sdram_parms.c, and then pass into where it is needed.

Hung-Te Lin (Code Review)

8:06 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

Patch Set 2:

sorry, sdram_configs/*.c.

Different boards may have different mapping for RAM code, so we should look at config directly.

Paul Menzel (Code Review)

11:55 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34433/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/2//COMMIT_MSG@9 PS2, Line 9: read the ramid to get the DRAM type of current platform Please elaborate. May current guess, but no idea what `ram_code()` does actually.

...

The platform supports two DRAM types: discrete and EMCP. (What is that?) The type is encoded on the board by reading certain GPIOs. Add support for reading that.

https://review.coreboot.org/c/coreboot/+/34433/2//COMMIT_MSG@13 PS2, Line 13: pass Verb?: passes

huayang duan (Code Review)

23 Jul 23 Jul

2:29 a.m.

Hello Yu-Ping Wu, Julius Werner, You-Cheng Syu, Sj Huang, Hung-Te Lin, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34433

to look at the new patch set (#3).

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

mediatek/mt8183: support get current DRAM type

Read the ramid to get the DRAM type of current platform. For EMCP DDR, the max support DRAM frequency was 3600Mbps, but for DISCRETE DDR, the max support DRAM frequency was 3200Mbps. So for different DDR type, need do different DDR init flow.

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/3

huayang duan (Code Review)

2:36 a.m.

huayang duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

Patch Set 3:

(1 comment)

...

Patch Set 2:

sorry, sdram_configs/*.c.

Different boards may have different mapping for RAM code, so we should look at config directly.

---> I moved this function into the src/mainboard/google/kukui/sdram_parms.c. For google kukui borads, different boards may mounted different RAM, so we should get correct DDR type by read RAM code.

https://review.coreboot.org/c/coreboot/+/34433/2/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:

...

this is a board-specific thing and we should not put that in soc folder. […]

I moved this function into the src/mainboard/google/kukui/sdram_parms.c Done

Hung-Te Lin (Code Review)

2:36 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/sdram_configs.c:

https://review.coreboot.org/c/coreboot/+/34433/3/src/mainboard/google/kukui/... PS3, Line 47: switch (ramcode) { no, we are not doing a switch-case here.

as my last comment said, it's sdram_configs/*.c, not sdram_config.c .

You should put the type info in individual DRAM configuration c struct / file, not doing switch here.

Hung-Te Lin (Code Review)

2:37 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/3/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:

https://review.coreboot.org/c/coreboot/+/34433/3/src/soc/mediatek/mt8183/emi... PS3, Line 15: : #include <boardid.h> remove this

Hung-Te Lin (Code Review)

2:39 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/3/src/soc/mediatek/mt8183/inc... File src/soc/mediatek/mt8183/include/soc/emi.h:

https://review.coreboot.org/c/coreboot/+/34433/3/src/soc/mediatek/mt8183/inc... PS3, Line 36: enum { : DRAM_TYPE_DISCRETE, : DRAM_TYPE_EMCP, : }; move this before 'struct sdram_parms, and make type, i..e,

enum DRAM_TYPE { DRAM_TYPE_DISCRETE, ... };

struct sdram_params { enum DRAM_TYPE dram_type; u32 impedance[2][4]; ...

Paul Menzel (Code Review)

9:27 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

Patch Set 3:

(5 comments)

Thank you for updating the commit message.

https://review.coreboot.org/c/coreboot/+/34433/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/3//COMMIT_MSG@10 PS3, Line 10: support supported

https://review.coreboot.org/c/coreboot/+/34433/3//COMMIT_MSG@10 PS3, Line 10: was is

https://review.coreboot.org/c/coreboot/+/34433/3//COMMIT_MSG@11 PS3, Line 11: was is

https://review.coreboot.org/c/coreboot/+/34433/3//COMMIT_MSG@11 PS3, Line 11: support supported

https://review.coreboot.org/c/coreboot/+/34433/3//COMMIT_MSG@12 PS3, Line 12: need do need to do

huayang duan (Code Review)

26 Jul 26 Jul

1:54 a.m.

Hello DAWEI CHIEN, Yu-Ping Wu, Julius Werner, You-Cheng Syu, Sj Huang, Hung-Te Lin, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34433

to look at the new patch set (#5).

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

mediatek/mt8183: support get current DRAM type

Read the ram-id to get the DRAM type of current platform. For EMCP DDR, the max supported DRAM frequency is 3600Mbps, but for DISCRETE DDR, the max supported DRAM frequency is 3200Mbps. So for different DDR type, need to do different DDR init flow.

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

Change-Id: Icf875427347418f796cbf193070bf047844d2267 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/sdram_configs.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMALHR-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDH6001DA-B422-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-MT29VZZZAD8DQKSL-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-MT53E1G32D4NQ-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-SDADA4CR-128G-4GB.c M src/soc/mediatek/mt8183/include/soc/emi.h 9 files changed, 19 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/5

huayang duan (Code Review)

1:56 a.m.

huayang duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

Patch Set 5:

(7 comments)

https://review.coreboot.org/c/coreboot/+/34433/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/3//COMMIT_MSG@10 PS3, Line 10: was

...

is

Done

https://review.coreboot.org/c/coreboot/+/34433/3//COMMIT_MSG@10 PS3, Line 10: support

...

supported

Done

https://review.coreboot.org/c/coreboot/+/34433/3//COMMIT_MSG@11 PS3, Line 11: support

...

supported

Done

https://review.coreboot.org/c/coreboot/+/34433/3//COMMIT_MSG@11 PS3, Line 11: was

...

is

Done

https://review.coreboot.org/c/coreboot/+/34433/3//COMMIT_MSG@12 PS3, Line 12: need do

...

need to do

Done

https://review.coreboot.org/c/coreboot/+/34433/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/sdram_configs.c:

https://review.coreboot.org/c/coreboot/+/34433/3/src/mainboard/google/kukui/... PS3, Line 47: switch (ramcode) {

...

no, we are not doing a switch-case here. […]

Done

https://review.coreboot.org/c/coreboot/+/34433/3/src/soc/mediatek/mt8183/inc... File src/soc/mediatek/mt8183/include/soc/emi.h:

https://review.coreboot.org/c/coreboot/+/34433/3/src/soc/mediatek/mt8183/inc... PS3, Line 36: enum { : DRAM_TYPE_DISCRETE, : DRAM_TYPE_EMCP, : };

...

move this before 'struct sdram_parms, and make type, i..e, […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 5 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 26 Jul 2019 01:56:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org Gerrit-MessageType: comment

DAWEI CHIEN (Code Review)

31 Jul 31 Jul

6:49 a.m.

DAWEI CHIEN has uploaded a new patch set (#7) to the change originally created by huayang duan. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

mediatek/mt8183: support get current DRAM type

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

Change-Id: Icf875427347418f796cbf193070bf047844d2267 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/Makefile.inc M src/mainboard/google/kukui/sdram_configs.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMALHR-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDH6001DA-B422-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-MT29VZZZAD8DQKSL-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-MT53E1G32D4NQ-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-SDADA4CR-128G-4GB.c M src/soc/mediatek/mt8183/include/soc/emi.h 10 files changed, 20 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/7

Hung-Te Lin (Code Review)

2:41 p.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/7/src/mainboard/google/kukui/... File src/mainboard/google/kukui/sdram_configs.c:

https://review.coreboot.org/c/coreboot/+/34433/7/src/mainboard/google/kukui/... PS7, Line 44: : int get_dram_type(void) : { : return params.dram_type; : } I think this is not really needed?

In the following change that calls this function, it's inside mt_set_emi, which has sdram_params as argument, so it can directly access params.dram_type for it.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 7 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 31 Jul 2019 14:41:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

DAWEI CHIEN (Code Review)

6 Aug 6 Aug

9:43 a.m.

DAWEI CHIEN has uploaded a new patch set (#9) to the change originally created by huayang duan. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

mediatek/mt8183: support get current DRAM type

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/9

Hung-Te Lin (Code Review)

10:07 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

Patch Set 9:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34433/9/src/soc/mediatek/mt8183/inc... File src/soc/mediatek/mt8183/include/soc/emi.h:

https://review.coreboot.org/c/coreboot/+/34433/9/src/soc/mediatek/mt8183/inc... PS9, Line 29: enum The params will be compiled as C struct and stored as blob, so I think a more explicit type is better. enum is considered as int, and we should use a u32 here instead.

https://review.coreboot.org/c/coreboot/+/34433/9/src/soc/mediatek/mt8183/inc... PS9, Line 50: int get_dram_type(void); I think we should not declare this in soc emi.h; instead I think mainboard.c can simply call get_sdram_config() and use params.dram_type

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 9 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 06 Aug 2019 10:07:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

7 Aug 7 Aug

3:10 a.m.

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: support get current DRAM type ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/9//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/9//COMMIT_MSG@7 PS9, Line 7: support Capitalize

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 9 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 07 Aug 2019 03:10:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

huayang duan (Code Review)

6:46 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Capitalize get current DRAM type

Hello Yu-Ping Wu, DAWEI CHIEN, Julius Werner, You-Cheng Syu, Sj Huang, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34433

to look at the new patch set (#10).

Change subject: mediatek/mt8183: Capitalize get current DRAM type ......................................................................

mediatek/mt8183: Capitalize get current DRAM type

Read the sdram config to get the DRAM type of current platform. For EMCP DDR, the max supported DRAM frequency is 3600Mbps, but for DISCRETE DDR, the max supported DRAM frequency is 3200Mbps. So for different DDR type, need to do different DDR init flow.

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

Change-Id: Icf875427347418f796cbf193070bf047844d2267 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMALHR-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDH6001DA-B422-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-MT29VZZZAD8DQKSL-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-MT53E1G32D4NQ-4GB.c M src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-SDADA4CR-128G-4GB.c M src/soc/mediatek/mt8183/emi.c M src/soc/mediatek/mt8183/include/soc/emi.h 9 files changed, 18 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/10

Yu-Ping Wu (Code Review)

6:51 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Capitalize get current DRAM type

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: Capitalize get current DRAM type ......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/9//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/9//COMMIT_MSG@7 PS9, Line 7: support

...

Capitalize

I mean "Support" ...

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 10 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 07 Aug 2019 06:51:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: comment

huayang duan (Code Review)

6:53 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

Hello Yu-Ping Wu, DAWEI CHIEN, Julius Werner, You-Cheng Syu, Sj Huang, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34433

to look at the new patch set (#11).

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

mediatek/mt8183: Support get current DRAM type

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/11

Huayang Duan (Code Review)

6:54 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

Patch Set 11:

(3 comments)

https://review.coreboot.org/c/coreboot/+/34433/9//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/9//COMMIT_MSG@7 PS9, Line 7: support

...

Capitalize

Done

https://review.coreboot.org/c/coreboot/+/34433/9/src/soc/mediatek/mt8183/inc... File src/soc/mediatek/mt8183/include/soc/emi.h:

https://review.coreboot.org/c/coreboot/+/34433/9/src/soc/mediatek/mt8183/inc... PS9, Line 29: enum

...

The params will be compiled as C struct and stored as blob, so I think a more explicit type is bette […]

Done

https://review.coreboot.org/c/coreboot/+/34433/9/src/soc/mediatek/mt8183/inc... PS9, Line 50: int get_dram_type(void);

...

I think we should not declare this in soc emi.h; instead I think mainboard. […]

the DDR driver get the dram type first for DRAM calibration flow. For EMCP DDR, the max supported DRAM frequency is 3600Mbps, so driver will do 3600Mbps data rate init. but for DISCRETE DDR, the max supported DRAM frequency is 3200Mbps, driver will do 3200Mbps data rate init.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 11 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 07 Aug 2019 06:54:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

8 Aug 8 Aug

4:16 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

Patch Set 11:

since discrete or not is actually a MB layout thing (you can't really replace and install eMCP on discrete boards) I'd recommend changing this to board definitions, i.e., in Kconfig add:

KUKUI_HAS_EMCP

And then you can determine the right type in code as

if (CONFIG_KUKUI_HAS_EMCP) ...

This should be done inside src/mainboard/google/kukui/*. If some module in src/soc/mediatek needs such info, that should be passed and sent by mainboard/google/kukui/*.

Also, to make sure we won't be using wrong combination, you can still add the DRAM type in DRAM config, and ten we can compare with CONFIG_KUKUI_HAS_EMCP to see if the system was using right ocnfig.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 11 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: Dawei Chien dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 08 Aug 2019 04:16:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Huayang Duan (Code Review)

9:26 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

Patch Set 12:

...

Patch Set 11:

since discrete or not is actually a MB layout thing (you can't really replace and install eMCP on discrete boards) I'd recommend changing this to board definitions, i.e., in Kconfig add:

KUKUI_HAS_EMCP

And then you can determine the right type in code as

if (CONFIG_KUKUI_HAS_EMCP) ...

This should be done inside src/mainboard/google/kukui/*. If some module in src/soc/mediatek needs such info, that should be passed and sent by mainboard/google/kukui/*.

Also, to make sure we won't be using wrong combination, you can still add the DRAM type in DRAM config, and ten we can compare with CONFIG_KUKUI_HAS_EMCP to see if the system was using right ocnfig.

how can I distinguish the current build is EMCP or discrete? which Macro should I using to judge current type? I see BOARD_GOOGLE_KUKUI and BOARD_GOOGLE_KRANE all be defined at https://review.coreboot.org/plugins/gitiles/coreboot/+/f686c6395d10ac6190c01... And the build binary of EMCP is image-krane.dev.img, and kukui is image-kukui.dev.img

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 12 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: Dawei Chien dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 08 Aug 2019 09:26:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

9:48 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

Patch Set 12:

Today there's only Krane using eMCP, so we should add in Kconfig:

config KUKUI_HAS_EMCP bool default y if BOARD_GOOGLE_KRANE default n

And then in code you can do

if (CONFIG_KUKUI_HAS_EMCP) .... // do 3600 else .... // do 3200

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 12 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: Dawei Chien dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 08 Aug 2019 09:48:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Julius Werner (Code Review)

9 Aug 9 Aug

8:02 p.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

Patch Set 12:

I like the idea of using Kconfig, if this is fixed per board that seems like the best option. But I'd define it in the SoC Kconfig

config MT8183_DRAM_EMCP def_bool n

and then in Kukui's BOARD_SPECIFIC_OPTIONS you can just do

select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 12 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: Dawei Chien dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 09 Aug 2019 20:02:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Huayang Duan (Code Review)

10 Aug 10 Aug

3:19 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

Patch Set 12:

...

Patch Set 12:

I like the idea of using Kconfig, if this is fixed per board that seems like the best option. But I'd define it in the SoC Kconfig

config MT8183_DRAM_EMCP def_bool n

and then in Kukui's BOARD_SPECIFIC_OPTIONS you can just do

select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE

does only BOARD_GOOGLE_KUKUI be select when building image-kukui.dev.img (BOARD_GOOGLE_KRANE not be selected)

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 12 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: Dawei Chien dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 10 Aug 2019 03:19:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Huayang Duan (Code Review)

3:19 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

Patch Set 12:

...

Patch Set 12:

...
Patch Set 12:

I like the idea of using Kconfig, if this is fixed per board that seems like the best option. But I'd define it in the SoC Kconfig

config MT8183_DRAM_EMCP def_bool n

and then in Kukui's BOARD_SPECIFIC_OPTIONS you can just do

select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE

does only BOARD_GOOGLE_KUKUI be select when building image-kukui.dev.img (BOARD_GOOGLE_KRANE not be selected)

I see BOARD_GOOGLE_KUKUI and BOARD_GOOGLE_KRANE all be defined at https://review.coreboot.org/plugins/gitiles/coreboot/+/f686c6395d10ac6190c01...

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 12 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: Dawei Chien dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 10 Aug 2019 03:19:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Julius Werner (Code Review)

5:46 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

Patch Set 12:

...

...
does only BOARD_GOOGLE_KUKUI be select when building image-kukui.dev.img (BOARD_GOOGLE_KRANE not be selected)

I see BOARD_GOOGLE_KUKUI and BOARD_GOOGLE_KRANE all be defined at https://review.coreboot.org/plugins/gitiles/coreboot/+/f686c6395d10ac6190c01...

Only one of the BOARD_GOOGLE_xxx options is true for any given build.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 12 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: Dawei Chien dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 10 Aug 2019 05:46:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

huayang duan (Code Review)

12 Aug 12 Aug

6:24 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

Hello Yu-Ping Wu, Dawei Chien, Julius Werner, You-Cheng Syu, Sj Huang, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34433

to look at the new patch set (#13).

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

mediatek/mt8183: Support get current DRAM type

Get the DRAM type of current platform from build config. For EMCP DDR, the max supported DRAM frequency is 3600Mbps, but for DISCRETE DDR, the max supported DRAM frequency is 3200Mbps. So for different DDR type, need to do different DDR init flow.

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

Change-Id: Icf875427347418f796cbf193070bf047844d2267 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/Kconfig M src/soc/mediatek/mt8183/Kconfig M src/soc/mediatek/mt8183/emi.c M src/soc/mediatek/mt8183/include/soc/emi.h 4 files changed, 20 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/13

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 13 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: Dawei Chien dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Hung-Te Lin (Code Review)

6:28 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/13/src/soc/mediatek/mt8183/Kc... File src/soc/mediatek/mt8183/Kconfig:

https://review.coreboot.org/c/coreboot/+/34433/13/src/soc/mediatek/mt8183/Kc... PS13, Line 25: MT8183_DRAM_EMCP if you already have this config defined in src/soc/..., then I think we don't need to create another function (get_dram_type()). Just use this config in your code.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 13 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: Dawei Chien dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 12 Aug 2019 06:28:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

huayang duan (Code Review)

7:31 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

Hello Yu-Ping Wu, Dawei Chien, Julius Werner, You-Cheng Syu, Sj Huang, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34433

to look at the new patch set (#14).

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

mediatek/mt8183: Support get current DRAM type

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/14

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 14 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: Dawei Chien dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Huayang Duan (Code Review)

7:31 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

Patch Set 14:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/13/src/soc/mediatek/mt8183/Kc... File src/soc/mediatek/mt8183/Kconfig:

https://review.coreboot.org/c/coreboot/+/34433/13/src/soc/mediatek/mt8183/Kc... PS13, Line 25: MT8183_DRAM_EMCP

...

if you already have this config defined in src/soc/... […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 14 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: Dawei Chien dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 12 Aug 2019 07:31:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

9:10 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

Patch Set 14:

Thanks. I think we're pretty close. Given that there is simply Kconfig now, the commit description does not apply anymore.

Can you move the mt8183/Kconfig changes to the "Support DDR frequency 3600Mbps", and move the kukui/Kconfig change to a "mb/google/kukui: Enable 3600Mps DDR for boards with EMCP".

That should make things more clear.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 14 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: Dawei Chien dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 12 Aug 2019 09:10:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Julius Werner (Code Review)

13 Aug 13 Aug

1:04 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

Patch Set 14:

(2 comments)

This mostly looks good to me now.

https://review.coreboot.org/c/coreboot/+/34433/14/src/soc/mediatek/mt8183/Kc... File src/soc/mediatek/mt8183/Kconfig:

https://review.coreboot.org/c/coreboot/+/34433/14/src/soc/mediatek/mt8183/Kc... PS14, Line 26: bool "EMCP platform should select this config" This should only be selected by the mainboard Kconfig and not by the user in menuconfig, so it shouldn't be user visible (i.e. only write 'bool' here, without a user-readable option name next to it).

https://review.coreboot.org/c/coreboot/+/34433/14/src/soc/mediatek/mt8183/Kc... PS14, Line 27: default n Even though it's not user-visible, please add a small 'help' section here as a comment to explain what the option is for.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 14 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: Dawei Chien dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 13 Aug 2019 01:04:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

DAWEI CHIEN (Code Review)

15 Aug 15 Aug

7:38 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

DAWEI CHIEN has uploaded a new patch set (#15) to the change originally created by huayang duan. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

mediatek/mt8183: Support get current DRAM type

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/15

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 15 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Hung-Te Lin (Code Review)

8:02 a.m.

New subject: Change in coreboot[master]: mediatek/mt8183: Support get current DRAM type

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mediatek/mt8183: Support get current DRAM type ......................................................................

Patch Set 15:

(3 comments)

https://review.coreboot.org/c/coreboot/+/34433/15//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/15//COMMIT_MSG@7 PS15, Line 7: Support get current DRAM ty Add new config for EMCP

https://review.coreboot.org/c/coreboot/+/34433/15//COMMIT_MSG@8 PS15, Line 8: : Get the DRAM type of current platform from build config. : For EMCP DDR, the max supported DRAM frequency is 3600Mbps, : but for DISCRETE DDR, the max supported DRAM frequency is 3200Mbps. : So for different DDR type, need to do different DDR init flow. Devices using eMCP may run in a higher DRAM frequency (e.g., 3600Mbps) while discrete DRAM can only run 3200Mbps.

A new Kconfig is introduced so mainboard can select right config to indicate if the board supports eMCP or not.

https://review.coreboot.org/c/coreboot/+/34433/15/src/soc/mediatek/mt8183/Kc... File src/soc/mediatek/mt8183/Kconfig:

https://review.coreboot.org/c/coreboot/+/34433/15/src/soc/mediatek/mt8183/Kc... PS15, Line 26: bool "EMCP platform should select this config" we should not allow setting this from menu. Please change to def_bool n

and move the "EMCP" into help section.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 15 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 15 Aug 2019 08:02:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

huayang duan (Code Review)

19 Aug 19 Aug

9:27 a.m.

New subject: Change in coreboot[master]: UPSTREAM: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR

Hello Yu-Ping Wu, DAWEI CHIEN, Julius Werner, You-Cheng Syu, Sj Huang, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34433

to look at the new patch set (#16).

Change subject: UPSTREAM: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR ......................................................................

UPSTREAM: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR

Devices using eMCP may run in a high DRAM frequency (e.g., 3600Mbs) while discrete DRAM can only run at 3200Mbps.

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

Change-Id: Icf875427347418f796cbf193070bf047844d2267 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/16

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 16 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

10:27 a.m.

New subject: Change in coreboot[master]: UPSTREAM: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: UPSTREAM: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR ......................................................................

Patch Set 17:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/17//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/17//COMMIT_MSG@7 PS17, Line 7: UPSTREAM: remove

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 17 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 19 Aug 2019 10:27:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

DAWEI CHIEN (Code Review)

20 Aug 20 Aug

5:44 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR

DAWEI CHIEN has uploaded a new patch set (#18) to the change originally created by huayang duan. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR ......................................................................

mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR

Devices using eMCP may run in a high DRAM frequency (e.g., 3600Mbs) while discrete DRAM can only run at 3200Mbps.

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

Change-Id: Icf875427347418f796cbf193070bf047844d2267 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/18

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 18 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Hung-Te Lin (Code Review)

21 Aug 21 Aug

3:19 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR ......................................................................

Patch Set 19: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 19 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 21 Aug 2019 03:19:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

huayang duan (Code Review)

1:42 p.m.

New subject: Change in coreboot[master]: UPSTREAM: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR

Hello Yu-Ping Wu, DAWEI CHIEN, Julius Werner, You-Cheng Syu, Sj Huang, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34433

to look at the new patch set (#20).

Change subject: UPSTREAM: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR ......................................................................

UPSTREAM: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR

Devices using eMCP may run in a high DRAM frequency (e.g., 3600Mbs) while discrete DRAM can only run at 3200Mbps.

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

Change-Id: Icf875427347418f796cbf193070bf047844d2267 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/20

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 20 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Julius Werner (Code Review)

6:08 p.m.

New subject: Change in coreboot[master]: UPSTREAM: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: UPSTREAM: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR ......................................................................

Patch Set 20:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/20//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/20//COMMIT_MSG@7 PS20, Line 7: UPSTREAM: This doesn't belong here.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 20 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 21 Aug 2019 18:08:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

huayang duan (Code Review)

28 Aug 28 Aug

9:33 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR

Hello Yu-Ping Wu, DAWEI CHIEN, Julius Werner, You-Cheng Syu, Sj Huang, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34433

to look at the new patch set (#21).

Change subject: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR ......................................................................

mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR

Devices using eMCP may run in a high DRAM frequency (e.g., 3600Mbs) while discrete DRAM can only run at 3200Mbps.

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

Change-Id: Icf875427347418f796cbf193070bf047844d2267 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/21

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 21 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Huayang Duan (Code Review)

9:41 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR

Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR ......................................................................

Patch Set 21:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/20//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/20//COMMIT_MSG@7 PS20, Line 7: UPSTREAM:

...

This doesn't belong here.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 21 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 28 Aug 2019 09:41:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner jwerner@chromium.org Gerrit-MessageType: comment

Paul Menzel (Code Review)

29 Aug 29 Aug

7:51 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mb/google/kukui: Enable 3600Mbps for borads with EMCP DDR ......................................................................

Patch Set 22:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/22//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/22//COMMIT_MSG@7 PS22, Line 7: borads boards

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 22 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 29 Aug 2019 07:51:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

8:47 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable 3600Mbps for boards with EMCP DDR

Yu-Ping Wu has uploaded a new patch set (#28) to the change originally created by huayang duan. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mb/google/kukui: Enable 3600Mbps for boards with EMCP DDR ......................................................................

mb/google/kukui: Enable 3600Mbps for boards with EMCP DDR

Devices using eMCP may run in a high DRAM frequency (e.g., 3600Mbs) while discrete DRAM can only run at 3200Mbps.

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

Change-Id: Icf875427347418f796cbf193070bf047844d2267 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/28

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 28 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Yu-Ping Wu (Code Review)

8:47 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable 3600Mbps for boards with EMCP DDR

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mb/google/kukui: Enable 3600Mbps for boards with EMCP DDR ......................................................................

Patch Set 27:

(11 comments)

https://review.coreboot.org/c/coreboot/+/34433/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/2//COMMIT_MSG@13 PS2, Line 13: pass

...

Verb?: passes

Done

https://review.coreboot.org/c/coreboot/+/34433/15//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/15//COMMIT_MSG@7 PS15, Line 7: Support get current DRAM ty

...

Add new config for EMCP

Done

...

Devices using eMCP may run in a higher DRAM frequency (e.g. […]

Done

https://review.coreboot.org/c/coreboot/+/34433/17//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/17//COMMIT_MSG@7 PS17, Line 7: UPSTREAM:

...

remove

Done

https://review.coreboot.org/c/coreboot/+/34433/22//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/22//COMMIT_MSG@7 PS22, Line 7: borads

...

boards

Done

https://review.coreboot.org/c/coreboot/+/34433/7/src/mainboard/google/kukui/... File src/mainboard/google/kukui/sdram_configs.c:

https://review.coreboot.org/c/coreboot/+/34433/7/src/mainboard/google/kukui/... PS7, Line 44: : int get_dram_type(void) : { : return params.dram_type; : }

...

I think this is not really needed? […]

Done

https://review.coreboot.org/c/coreboot/+/34433/14/src/soc/mediatek/mt8183/Kc... File src/soc/mediatek/mt8183/Kconfig:

https://review.coreboot.org/c/coreboot/+/34433/14/src/soc/mediatek/mt8183/Kc... PS14, Line 26: bool "EMCP platform should select this config"

...

This should only be selected by the mainboard Kconfig and not by the user in menuconfig, so it shoul […]

Done

https://review.coreboot.org/c/coreboot/+/34433/14/src/soc/mediatek/mt8183/Kc... PS14, Line 27: default n

...

Even though it's not user-visible, please add a small 'help' section here as a comment to explain wh […]

Done

https://review.coreboot.org/c/coreboot/+/34433/15/src/soc/mediatek/mt8183/Kc... File src/soc/mediatek/mt8183/Kconfig:

https://review.coreboot.org/c/coreboot/+/34433/15/src/soc/mediatek/mt8183/Kc... PS15, Line 26: bool "EMCP platform should select this config"

...

we should not allow setting this from menu. Please change to def_bool n […]

Done

https://review.coreboot.org/c/coreboot/+/34433/3/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:

https://review.coreboot.org/c/coreboot/+/34433/3/src/soc/mediatek/mt8183/emi... PS3, Line 15: : #include <boardid.h>

...

remove this

Done

https://review.coreboot.org/c/coreboot/+/34433/9/src/soc/mediatek/mt8183/inc... File src/soc/mediatek/mt8183/include/soc/emi.h:

https://review.coreboot.org/c/coreboot/+/34433/9/src/soc/mediatek/mt8183/inc... PS9, Line 50: int get_dram_type(void);

...

the DDR driver get the dram type first for DRAM calibration flow. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 27 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 29 Aug 2019 08:47:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner jwerner@chromium.org Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org Comment-In-Reply-To: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

8:48 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable 3600Mbps for boards with EMCP DDR

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mb/google/kukui: Enable 3600Mbps for boards with EMCP DDR ......................................................................

Patch Set 28:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/2//COMMIT_MSG@9 PS2, Line 9: read the ramid to get the DRAM type of current platform

...

Please elaborate. May current guess, but no idea what `ram_code()` does actually. […]

Is the latest commit message okay for you?

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 28 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 29 Aug 2019 08:48:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

2 Sep 2 Sep

3:19 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable 3600Mbps for boards with EMCP DDR

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mb/google/kukui: Enable 3600Mbps for boards with EMCP DDR ......................................................................

Patch Set 30:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/30//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/30//COMMIT_MSG@9 PS30, Line 9: Mbs Mbps

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 30 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 02 Sep 2019 03:19:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

6:01 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable 3600Mbps for boards with EMCP DDR

Yu-Ping Wu has uploaded a new patch set (#31) to the change originally created by huayang duan. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mb/google/kukui: Enable 3600Mbps for boards with EMCP DDR ......................................................................

mb/google/kukui: Enable 3600Mbps for boards with EMCP DDR

Devices using eMCP may run in a high DRAM frequency (e.g., 3600Mbps) while discrete DRAM can only run at 3200Mbps.

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

Change-Id: Icf875427347418f796cbf193070bf047844d2267 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/31

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 31 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Yu-Ping Wu (Code Review)

6:01 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable 3600Mbps for boards with EMCP DDR

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mb/google/kukui: Enable 3600Mbps for boards with EMCP DDR ......................................................................

Patch Set 31:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/30//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/30//COMMIT_MSG@9 PS30, Line 9: Mbs

...

Mbps

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 31 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 02 Sep 2019 06:01:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

10 Sep 10 Sep

8:16 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable MT8183_DRAM_EMCP

Yu-Ping Wu has uploaded a new patch set (#35) to the change originally created by huayang duan. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP ......................................................................

mb/google/kukui: Enable MT8183_DRAM_EMCP

MT8183_DRAM_EMCP is enabled for devices using eMCP to run at a high DRAM frequency (e.g., 3600Mbps).

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform.

Change-Id: Icf875427347418f796cbf193070bf047844d2267 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/35

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 35 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Yu-Ping Wu (Code Review)

10:32 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable MT8183_DRAM_EMCP

Yu-Ping Wu has uploaded a new patch set (#37) to the change originally created by huayang duan. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP ......................................................................

mb/google/kukui: Enable MT8183_DRAM_EMCP

MT8183_DRAM_EMCP is enabled for devices using eMCP to run at a high DRAM frequency (e.g., 3600Mbps).

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

Change-Id: Icf875427347418f796cbf193070bf047844d2267 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34433/37

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 37 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Hung-Te Lin (Code Review)

2:08 p.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable MT8183_DRAM_EMCP

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP ......................................................................

Patch Set 37: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/34433/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34433/2//COMMIT_MSG@9 PS2, Line 9: read the ramid to get the DRAM type of current platform

...

Is the latest commit message okay for you?

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 37 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 10 Sep 2019 14:08:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Georgi (Code Review)

8:06 p.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable MT8183_DRAM_EMCP

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/34433 )

Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP ......................................................................

mb/google/kukui: Enable MT8183_DRAM_EMCP

MT8183_DRAM_EMCP is enabled for devices using eMCP to run at a high DRAM frequency (e.g., 3600Mbps).

BUG=b:80501386 BRANCH=none TEST=Memory test passes on EMCP platform

Change-Id: Icf875427347418f796cbf193070bf047844d2267 Signed-off-by: Huayang Duan huayang.duan@mediatek.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34433 Reviewed-by: Hung-Te Lin hungte@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved

diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index d16e2ed..24a8e43 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -43,6 +43,7 @@ select MAINBOARD_FORCE_NATIVE_VGA_INIT select HAVE_LINEAR_FRAMEBUFFER select DRIVER_PARADE_PS8640 if BOARD_GOOGLE_JACUZZI + select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE

config MAINBOARD_DIR string

-- To view, visit https://review.coreboot.org/c/coreboot/+/34433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267 Gerrit-Change-Number: 34433 Gerrit-PatchSet: 38 Gerrit-Owner: huayang duan huayangduan@gmail.com Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: huayang duan huayangduan@gmail.com Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1705

days inactive

1758

days old

coreboot-gerrit@coreboot.org

56 comments

9 participants

tags (0)

participants (9)

build bot (Jenkins) (Code Review)
DAWEI CHIEN (Code Review)
Huayang Duan (Code Review)
huayang duan (Code Review)
Hung-Te Lin (Code Review)
Julius Werner (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Yu-Ping Wu (Code Review)