huayang duan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34989 )
Change subject: mediatek/mt8183: Add new config for EMCP DDR ......................................................................
mediatek/mt8183: Add new config for EMCP DDR
Devices using eMCP may run in a high DRAM frequency (e.g., 3600Mbs) while discrete DRAM can only run at 3200Mbps. A new Kconfig is introduced so mainboard can select right config if the board support eMCP or not.
BUG=b:80501386 BRANCH=none TEST=Boots correctly and stress test pass on Kukui.
Change-Id: I9b73c8b512db5104896ea0d330d56e63eb50a44b Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/soc/mediatek/mt8183/Kconfig 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/34989/1
diff --git a/src/soc/mediatek/mt8183/Kconfig b/src/soc/mediatek/mt8183/Kconfig index c60cdea..a2f7a04 100644 --- a/src/soc/mediatek/mt8183/Kconfig +++ b/src/soc/mediatek/mt8183/Kconfig @@ -22,6 +22,12 @@ help This option enables additional DRAM related debug messages.
+config MT8183_DRAM_EMCP + bool + default n + help + The EMCP platform should select this config for using different DRAM frequency. + config MEMORY_TEST bool default y
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34989 )
Change subject: mediatek/mt8183: Add new config for EMCP DDR ......................................................................
Patch Set 2: Code-Review+2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34989 )
Change subject: mediatek/mt8183: Add new config for EMCP DDR ......................................................................
Patch Set 15: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/34989/15/src/soc/mediatek/mt8183/Kc... File src/soc/mediatek/mt8183/Kconfig:
https://review.coreboot.org/c/coreboot/+/34989/15/src/soc/mediatek/mt8183/Kc... PS15, Line 30: frequency. please move this to next line so we can fit in col 80.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34989 )
Change subject: mediatek/mt8183: Add new config for EMCP DDR ......................................................................
Patch Set 15:
can we rebase this to top of chain so we can merge earlyer? Also the CL to enable EMCP on Krane.
In fact I think we may even merge the two into one.
Yu-Ping Wu has uploaded a new patch set (#16) to the change originally created by huayang duan. ( https://review.coreboot.org/c/coreboot/+/34989 )
Change subject: mediatek/mt8183: Add new option for eMCP DDR ......................................................................
mediatek/mt8183: Add new option for eMCP DDR
Devices using eMCP may run at a high DRAM frequency (e.g., 3600Mbs) while those with discrete DRAM can only run at 3200Mbps. A new option MT8183_DRAM_EMCP is added to Kconfig for a mainboard to select, depending on whether it supports eMCP or not.
BUG=b:80501386 BRANCH=none TEST=Boots correctly on Kukui.
Change-Id: I9b73c8b512db5104896ea0d330d56e63eb50a44b Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/soc/mediatek/mt8183/Kconfig 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/34989/16
Yu-Ping Wu has uploaded a new patch set (#17) to the change originally created by huayang duan. ( https://review.coreboot.org/c/coreboot/+/34989 )
Change subject: mediatek/mt8183: Add new option for eMCP DDR ......................................................................
mediatek/mt8183: Add new option for eMCP DDR
Devices using eMCP may run at a high DRAM frequency (e.g., 3600Mbs) while those with discrete DRAM can only run at 3200Mbps. A new option MT8183_DRAM_EMCP is added to Kconfig for a mainboard to select, depending on whether it supports eMCP or not.
BUG=b:80501386 BRANCH=none TEST=Boots correctly on Kukui.
Change-Id: I9b73c8b512db5104896ea0d330d56e63eb50a44b Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/soc/mediatek/mt8183/Kconfig 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/34989/17
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34989 )
Change subject: mediatek/mt8183: Add new option for eMCP DDR ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34989/15/src/soc/mediatek/mt8183/Kc... File src/soc/mediatek/mt8183/Kconfig:
https://review.coreboot.org/c/coreboot/+/34989/15/src/soc/mediatek/mt8183/Kc... PS15, Line 30: frequency.
please move this to next line so we can fit in col 80.
Done
Yu-Ping Wu has uploaded a new patch set (#18) to the change originally created by huayang duan. ( https://review.coreboot.org/c/coreboot/+/34989 )
Change subject: mediatek/mt8183: Add new option for eMCP DDR ......................................................................
mediatek/mt8183: Add new option for eMCP DDR
Devices using eMCP may run at a high DRAM frequency (e.g., 3600Mbs) while those with discrete DRAM can only run at 3200Mbps. A new option MT8183_DRAM_EMCP is added to Kconfig for a mainboard to select, depending on whether it supports eMCP or not.
BUG=b:80501386 BRANCH=none TEST=Boots correctly on Kukui
Change-Id: I9b73c8b512db5104896ea0d330d56e63eb50a44b Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/soc/mediatek/mt8183/Kconfig 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/34989/18
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34989 )
Change subject: mediatek/mt8183: Add new option for eMCP DDR ......................................................................
Patch Set 18: Code-Review+2
thanks!
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/34989 )
Change subject: mediatek/mt8183: Add new option for eMCP DDR ......................................................................
mediatek/mt8183: Add new option for eMCP DDR
Devices using eMCP may run at a high DRAM frequency (e.g., 3600Mbs) while those with discrete DRAM can only run at 3200Mbps. A new option MT8183_DRAM_EMCP is added to Kconfig for a mainboard to select, depending on whether it supports eMCP or not.
BUG=b:80501386 BRANCH=none TEST=Boots correctly on Kukui
Change-Id: I9b73c8b512db5104896ea0d330d56e63eb50a44b Signed-off-by: Huayang Duan huayang.duan@mediatek.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34989 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Hung-Te Lin hungte@chromium.org --- M src/soc/mediatek/mt8183/Kconfig 1 file changed, 7 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved
diff --git a/src/soc/mediatek/mt8183/Kconfig b/src/soc/mediatek/mt8183/Kconfig index 9ac57bd..5ded0d3 100644 --- a/src/soc/mediatek/mt8183/Kconfig +++ b/src/soc/mediatek/mt8183/Kconfig @@ -23,6 +23,13 @@ help This option enables additional DRAM related debug messages.
+config MT8183_DRAM_EMCP + bool + default n + help + The eMCP platform should select this option to run at different DRAM + frequencies. + config MEMORY_TEST bool default y
-
huayang duan (Code Review) -
Hung-Te Lin (Code Review)
-
Patrick Georgi (Code Review)
-
Yu-Ping Wu (Code Review)