Attention is currently required from: Angel Pons, Michael Büchler, Michael Niewöhner, Michał Żygowski, Paul Menzel.
Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55232?usp=email )
Change subject: mb/dell: Add OptiPlex 7020/9020 port ......................................................................
Patch Set 27:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55232/comment/c1276ca4_3eaa0ba3 : PS22, Line 12: Linux
Please document the version of the Linux kernel used for testing, and the payload you used.
I've tested many kernel versions ranging from 4.4 to present day now, all worked.
https://review.coreboot.org/c/coreboot/+/55232/comment/61ed688a_b36311e0 : PS22, Line 15: VGA BIOS
Executed by SeaBIOS or by coreboot?
Been tested with both, but libgfxinit is the focus, and this port has been used by a few people for 2 years.
File src/mainboard/dell/optiplex_7020/Kconfig:
https://review.coreboot.org/c/coreboot/+/55232/comment/b3193ed3_a363333d : PS5, Line 23: needs flashed
needs to be
Acknowledged
https://review.coreboot.org/c/coreboot/+/55232/comment/21c2a870_a1429232 : PS5, Line 23: than
then
Acknowledged
File src/mainboard/dell/optiplex_7020/bootblock.c:
https://review.coreboot.org/c/coreboot/+/55232/comment/eda90a52_1813f898 : PS8, Line 108: // Changes LED color among a few other things (extracted from Dell's FW)
Here's an idea: If you know how to control LEDs, you can implement die_notify() and make some LEDs b […]
Acknowledged
File src/mainboard/dell/optiplex_7020/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/55232/comment/8aa13f9c_e998442d : PS1, Line 20: Scope (_SB) : { : Device (PCI0) : { : #include <northbridge/intel/haswell/acpi/hostbridge.asl> : #include <southbridge/intel/lynxpoint/acpi/pch.asl> : } : }
I usually write this as follows: […]
Done
File src/mainboard/dell/optiplex_7020/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/55232/comment/e8637c82_bf1511d5 : PS1, Line 11: -- TODO: Add DP ports to the list
I added all of them, I don't have many DP displays to test things with.
Acknowledged
File src/mainboard/dell/optiplex_9020/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55232/comment/6d26d64f_ce62e809 : PS25, Line 39: device pci 1c.1 off end :
The mini tower (MT) variant has two additional slots compared to the UFF variant: […]
I've implemented this now.