Attention is currently required from: Martin Roth, Jakub Czapiga, Julius Werner, Jan Dabros.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52159 )
Change subject: tests: Add lib/coreboot_table-test test case
......................................................................
Patch Set 2:
(1 comment)
File tests/lib/coreboot_table-test.c:
https://review.coreboot.org/c/coreboot/+/52159/comment/d85741f6_5e95e606
PS2, Line 329: test_write_tables
This seems like a very large test. What are you testing here, that each LB_TAG type is written correctly? If so, it seems like it should be multiple smaller tests.
Or if you're testing that write_tables works correctly, should the test be so flexible as to allow the records in any order, or should it check that write_table put the records in the same order that was specified?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52159
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d7d9ca43316bf514bb5ebd8909f441bcfa20eba
Gerrit-Change-Number: 52159
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Thu, 08 Apr 2021 20:31:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment