Change in ...coreboot[master]: ich7/i945: Use do_system_reset()

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

21 Apr 2019 21 Apr '19

4:51 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32378

Change subject: ich7/i945: Use do_system_reset() ......................................................................

ich7/i945: Use do_system_reset()

Use already defined do_system_reset() function.

Change-Id: Ieff4271c4a09d564d5f3415d8bc2c3843c8460f2 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/early_init.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/32378/1

diff --git a/src/northbridge/intel/i945/early_init.c b/src/northbridge/intel/i945/early_init.c index 0c92c4b..08a818c 100644 --- a/src/northbridge/intel/i945/early_init.c +++ b/src/northbridge/intel/i945/early_init.c @@ -15,6 +15,7 @@

#include <stdint.h> #include <stdlib.h> +#include <cf9_reset.h> #include <console/console.h> #include <arch/io.h> #include <device/pci_ops.h> @@ -518,8 +519,7 @@ reg32 &= ~(7 << 0); reg32 |= (3 << 0); DMIBAR32(0x224) = reg32; - outb(0x06, 0xcf9); - halt(); /* wait for reset */ + do_system_reset(); } } }

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Arthur Heymans (Code Review)

21 Apr 21 Apr

5:05 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32378 )

Change subject: ich7/i945: Use do_system_reset() ......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/32378/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32378/1//COMMIT_MSG@9 PS1, Line 9: superfluous space.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieff4271c4a09d564d5f3415d8bc2c3843c8460f2 Gerrit-Change-Number: 32378 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 21 Apr 2019 17:05:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

5:06 p.m.

Hello Patrick Rudolph, Arthur Heymans, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32378

to look at the new patch set (#2).

Change subject: ich7/i945: Use do_system_reset() ......................................................................

ich7/i945: Use do_system_reset()

Use already defined do_system_reset() function.

Change-Id: Ieff4271c4a09d564d5f3415d8bc2c3843c8460f2 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/early_init.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/32378/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieff4271c4a09d564d5f3415d8bc2c3843c8460f2 Gerrit-Change-Number: 32378 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

5:19 p.m.

New subject: Change in ...coreboot[master]: ich7/i945: Use system_reset()

Hello Patrick Rudolph, Arthur Heymans, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32378

to look at the new patch set (#3).

Change subject: ich7/i945: Use system_reset() ......................................................................

ich7/i945: Use system_reset()

Use already defined system_reset() function.

Change-Id: Ieff4271c4a09d564d5f3415d8bc2c3843c8460f2 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/early_init.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/32378/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/32378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieff4271c4a09d564d5f3415d8bc2c3843c8460f2 Gerrit-Change-Number: 32378 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

29 Apr 29 Apr

4 p.m.

New subject: Change in ...coreboot[master]: ich7/i945: Use system_reset()

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32378 )

Change subject: ich7/i945: Use system_reset() ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieff4271c4a09d564d5f3415d8bc2c3843c8460f2 Gerrit-Change-Number: 32378 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 29 Apr 2019 16:00:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

4:01 p.m.

New subject: Change in ...coreboot[master]: ich7/i945: Use system_reset()

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32378 )

Change subject: ich7/i945: Use system_reset() ......................................................................

ich7/i945: Use system_reset()

Use already defined system_reset() function.

Change-Id: Ieff4271c4a09d564d5f3415d8bc2c3843c8460f2 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32378 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/northbridge/intel/i945/early_init.c 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved

diff --git a/src/northbridge/intel/i945/early_init.c b/src/northbridge/intel/i945/early_init.c index 0c92c4b..a9de844 100644 --- a/src/northbridge/intel/i945/early_init.c +++ b/src/northbridge/intel/i945/early_init.c @@ -15,6 +15,7 @@

-- To view, visit https://review.coreboot.org/c/coreboot/+/32378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieff4271c4a09d564d5f3415d8bc2c3843c8460f2 Gerrit-Change-Number: 32378 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

2035

days inactive

2043

days old

coreboot-gerrit@coreboot.org

5 comments

3 participants

tags (0)

participants (3)

Arthur Heymans (Code Review)
HAOUAS Elyes (Code Review)
Nico Huber (Code Review)