Change in coreboot[master]: soc/intel/xeon_sp/skx: Properly set up MTRR's

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48673 )

Change subject: soc/intel/xeon_sp/skx: Properly set up MTRR's
......................................................................

soc/intel/xeon_sp/skx: Properly set up MTRR's

Don't depend on the MTRR setup left over from FSP-M ExitTempRam.

Change-Id: I299123b3cd3c37b4345102c20fda77bf261892a2
Signed-off-by: Arthur Heymans 
---
M src/soc/intel/xeon_sp/skx/cpu.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/48673/1

diff --git a/src/soc/intel/xeon_sp/skx/cpu.c b/src/soc/intel/xeon_sp/skx/cpu.c
index d36f11b..f9cd356 100644
--- a/src/soc/intel/xeon_sp/skx/cpu.c
+++ b/src/soc/intel/xeon_sp/skx/cpu.c
@@ -193,7 +193,8 @@
 {
    printk(BIOS_DEBUG, "%s: entry\n", __func__);

-	x86_setup_fixed_mtrrs();
+	x86_setup_mtrrs_with_detect();
+	x86_mtrr_check();
 }

static void post_mp_init(void)

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48673 )

Change subject: soc/intel/xeon_sp/skx: Properly set up MTRR's
......................................................................

Patch Set 1: Code-Review+2

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48673 )

Change subject: soc/intel/xeon_sp/skx: Properly set up MTRR's
......................................................................

Patch Set 1: Code-Review+2

I was just doing this same patch...

[Hung-Te Lin (Code Review)]

Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48673 )

Change subject: soc/intel/xeon_sp/skx: Properly set up MTRR's
......................................................................

soc/intel/xeon_sp/skx: Properly set up MTRR's

Don't depend on the MTRR setup left over from FSP-M ExitTempRam.

Change-Id: I299123b3cd3c37b4345102c20fda77bf261892a2
Signed-off-by: Arthur Heymans 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48673
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Marc Jones 
---
M src/soc/intel/xeon_sp/skx/cpu.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Marc Jones: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/intel/xeon_sp/skx/cpu.c b/src/soc/intel/xeon_sp/skx/cpu.c
index d36f11b..f9cd356 100644
--- a/src/soc/intel/xeon_sp/skx/cpu.c
+++ b/src/soc/intel/xeon_sp/skx/cpu.c
@@ -193,7 +193,8 @@
 {
    printk(BIOS_DEBUG, "%s: entry\n", __func__);

-	x86_setup_fixed_mtrrs();
+	x86_setup_mtrrs_with_detect();
+	x86_mtrr_check();
 }

static void post_mp_init(void)