Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73028 )
Change subject: soc/intel/cmn/gfx: Skip warning msg in ChromeOS normal mode ......................................................................
soc/intel/cmn/gfx: Skip warning msg in ChromeOS normal mode
This patch ensures avoiding displaying wrong warning msg as `Graphics hand-off block not found` during ChromeOS normal mode booting as FSP is not executing GFX PEIM hence, GFX hand-off HOB is expected to be missing.
TEST=Able to build and boot google/rex in normal mode w/o having warning msg.
Change-Id: Ia9192129852195f6183c0c43369cd33b253f9140 Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/73028 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Reviewed-by: Kapil Porwal kapilporwal@google.com Reviewed-by: Ivy Jian ivy.jian@quanta.corp-partner.google.com --- M src/soc/intel/common/block/graphics/graphics.c 1 file changed, 24 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Ivy Jian: Looks good to me, approved Kapil Porwal: Looks good to me, approved
diff --git a/src/soc/intel/common/block/graphics/graphics.c b/src/soc/intel/common/block/graphics/graphics.c index 14e7597..acef488 100644 --- a/src/soc/intel/common/block/graphics/graphics.c +++ b/src/soc/intel/common/block/graphics/graphics.c @@ -57,7 +57,7 @@ * In case of non-FSP solution, SoC need to select another * Kconfig to perform GFX initialization. */ - if (CONFIG(RUN_FSP_GOP)) { + if (CONFIG(RUN_FSP_GOP) && display_init_required()) { const struct soc_intel_common_config *config = chip_get_common_soc_structure(); fsp_report_framebuffer_info(graphics_get_framebuffer_address(), config->panel_orientation);