Attention is currently required from: Julius Werner, Paul Menzel, Yu-Ping Wu.
Yi Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79144?usp=email )
Change subject: libpayload: Fix the stack and data labels
......................................................................
Patch Set 8:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79144/comment/34fcdb20_25842c89 :
PS7, Line 9: the consistency between _stack/_estack and the other
: labels
Reads not so fluent to me. Maybe: […]
Done
File payloads/libpayload/arch/arm/libpayload.ldscript:
https://review.coreboot.org/c/coreboot/+/79144/comment/ce6b3761_dd06b29d :
PS7, Line 43: . = ALIGN(16);
Excuse my ignorance, but why the alignment?
Removed the unnecessary alignment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79144?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I589040f4db60b35813ea9f4ba9503244bd7def00
Gerrit-Change-Number: 79144
Gerrit-PatchSet: 8
Gerrit-Owner: Yi Chou
yich@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 30 Nov 2023 09:53:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment