Change in ...coreboot[master]: src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by ...
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33870
Change subject: src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware ......................................................................
src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware
G505S does not have any SAS or NVMe controllers and could not have a TPM, so it makes sense to disable the related SeaBIOS options for this laptop. This reduces the size of compiled SeaBIOS by 129344-110048 = 19296 bytes.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ib0183b7786ecd77bb0df923bc84908275f2fe14c --- M src/mainboard/lenovo/g505s/Kconfig A src/mainboard/lenovo/g505s/config_seabios 2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/33870/1
diff --git a/src/mainboard/lenovo/g505s/Kconfig b/src/mainboard/lenovo/g505s/Kconfig index 883ef27..b80019e 100644 --- a/src/mainboard/lenovo/g505s/Kconfig +++ b/src/mainboard/lenovo/g505s/Kconfig @@ -55,4 +55,8 @@ string default "1002,990b"
+config PAYLOAD_CONFIGFILE + string + default "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios" if PAYLOAD_SEABIOS + endif # BOARD_LENOVO_G505S diff --git a/src/mainboard/lenovo/g505s/config_seabios b/src/mainboard/lenovo/g505s/config_seabios new file mode 100644 index 0000000..1959fa3 --- /dev/null +++ b/src/mainboard/lenovo/g505s/config_seabios @@ -0,0 +1,7 @@ +### +### SeaBIOS custom configuration for Lenovo G505S +### +# CONFIG_MEGASAS is not set +# CONFIG_NVME is not set +# CONFIG_TCGBIOS is not set +#
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33870 )
Change subject: src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/33870/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33870/1//COMMIT_MSG@7 PS1, Line 7: src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware Commit summary should be around 55..65 chars.
https://review.coreboot.org/c/coreboot/+/33870/1//COMMIT_MSG@7 PS1, Line 7: src/mainboard `mb/` should suffice
https://review.coreboot.org/c/coreboot/+/33870/1//COMMIT_MSG@11 PS1, Line 11: This reduces the size of compiled SeaBIOS by 129344-110048 = 19296 bytes. Please adhere to the 72 chars line limit in commit messages.
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33870
to look at the new patch set (#2).
Change subject: mb/lenovo/g505s: Disable SeaBIOS options unsupported by hardware ......................................................................
mb/lenovo/g505s: Disable SeaBIOS options unsupported by hardware
G505S doesn't have any SAS or NVMe controllers and couldn't have a TPM, so it makes sense to disable the related SeaBIOS options for this board. This reduces the size of compiled SeaBIOS by 129344-110048=19296 bytes.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ib0183b7786ecd77bb0df923bc84908275f2fe14c --- M src/mainboard/lenovo/g505s/Kconfig A src/mainboard/lenovo/g505s/config_seabios 2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/33870/2
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33870 )
Change subject: mb/lenovo/g505s: Disable SeaBIOS options unsupported by hardware ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/33870/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33870/1//COMMIT_MSG@7 PS1, Line 7: src/mainboard
`mb/` should suffice
Done.
https://review.coreboot.org/c/coreboot/+/33870/1//COMMIT_MSG@7 PS1, Line 7: src/mainboard/lenovo/g505s: Disable SeaBIOS options not supported by hardware
Commit summary should be around 55..65 chars.
Done.
https://review.coreboot.org/c/coreboot/+/33870/1//COMMIT_MSG@11 PS1, Line 11: This reduces the size of compiled SeaBIOS by 129344-110048 = 19296 bytes.
Please adhere to the 72 chars line limit in commit messages.
Done, max length now is exactly 72 chars.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33870 )
Change subject: mb/lenovo/g505s: Disable SeaBIOS options unsupported by hardware ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/33870/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33870/2//COMMIT_MSG@9 PS2, Line 9: NVMe controllers Minor: NVMe is just a spec to access storage devices attached to PCIe. A "NVMe controller" on a mainboard would just be a PCIe port. I don't think the g505s has space for a NVMe drive, though.
(Some people would prove my last sentence wrong by attaching a NVMe SSD to the PCIe lanes that go to the dGPU, but they should not use default SeaBIOS settings anyway)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33870 )
Change subject: mb/lenovo/g505s: Disable SeaBIOS options unsupported by hardware ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33870/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33870/2//COMMIT_MSG@9 PS2, Line 9: NVMe controllers
Minor: NVMe is just a spec to access storage devices attached to PCIe. […]
Welp, even SeaBIOS calls these "NVMe controllers": https://github.com/coreboot/seabios/blob/master/src/Kconfig#L232
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33870 )
Change subject: mb/lenovo/g505s: Disable SeaBIOS options unsupported by hardware ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33870/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33870/2//COMMIT_MSG@9 PS2, Line 9: NVMe controllers
Welp, even SeaBIOS calls these "NVMe controllers": https://github. […]
I don't follow. Does it matter if you call it `NVMe controller` or `storage controller with NVMe interface`? What would you call it?
Also, you can plant any PCIe chips directly on a mainboard, not sure if anybody did it with an NVMe controller (plus flash) yet, but if not it won't take long.
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33870 )
Change subject: mb/lenovo/g505s: Disable SeaBIOS options unsupported by hardware ......................................................................
mb/lenovo/g505s: Disable SeaBIOS options unsupported by hardware
G505S doesn't have any SAS or NVMe controllers and couldn't have a TPM, so it makes sense to disable the related SeaBIOS options for this board. This reduces the size of compiled SeaBIOS by 129344-110048=19296 bytes.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ib0183b7786ecd77bb0df923bc84908275f2fe14c Reviewed-on: https://review.coreboot.org/c/coreboot/+/33870 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lenovo/g505s/Kconfig A src/mainboard/lenovo/g505s/config_seabios 2 files changed, 11 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/mainboard/lenovo/g505s/Kconfig b/src/mainboard/lenovo/g505s/Kconfig index 883ef27..b80019e 100644 --- a/src/mainboard/lenovo/g505s/Kconfig +++ b/src/mainboard/lenovo/g505s/Kconfig @@ -55,4 +55,8 @@ string default "1002,990b"
+config PAYLOAD_CONFIGFILE + string + default "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios" if PAYLOAD_SEABIOS + endif # BOARD_LENOVO_G505S diff --git a/src/mainboard/lenovo/g505s/config_seabios b/src/mainboard/lenovo/g505s/config_seabios new file mode 100644 index 0000000..1959fa3 --- /dev/null +++ b/src/mainboard/lenovo/g505s/config_seabios @@ -0,0 +1,7 @@ +### +### SeaBIOS custom configuration for Lenovo G505S +### +# CONFIG_MEGASAS is not set +# CONFIG_NVME is not set +# CONFIG_TCGBIOS is not set +#
-
Angel Pons (Code Review) -
Mike Banon (Code Review)
-
Nico Huber (Code Review)