Patch set 2:Code-Review +1
View Change
1 comment:
Commit Message:
Patch Set #2, Line 9: NVMe controllers
Minor: NVMe is just a spec to access storage devices attached to PCIe. A "NVMe controller" on a mainboard would just be a PCIe port. I don't think the g505s has space for a NVMe drive, though.
(Some people would prove my last sentence wrong by attaching a NVMe SSD to the PCIe lanes that go to the dGPU, but they should not use default SeaBIOS settings anyway)
To view, visit change 33870. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0183b7786ecd77bb0df923bc84908275f2fe14c
Gerrit-Change-Number: 33870
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sun, 07 Jul 2019 09:43:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment