Attention is currently required from: Fabian Groffen, Keith Hui.
Keith Hui has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/coreboot/+/75137?usp=email )
Change subject: mb/asus/p8z77-m: Remove settings to replicate OEM ......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75137/comment/9d6836a1_f3bd2728?usp... : PS4, Line 30: drq 0x1a = 0x02
Can you test with these two settings (0x1a,0x1b) retained if serial port still work? […]
After checking boardview and the SIO/PCH datasheets, I can confirm 0x1b must stay. It enables RESETCON_O signal, which is wired up on this board to tell PCH to reset.
https://review.coreboot.org/c/coreboot/+/75137/comment/fcf30479_770b1430?usp... : PS4, Line 32: drq 0x2c = 0x00 # GP27, 3VSBSW#, No TSI
This should stay. This is an Intel board, not AMD. […]
After checking boardview and the SIO/PCH datasheets, I can confirm this must stay. We need the pins to be in PECI mode so SIO can get temperature from CPU for fan control.
-
Keith Hui (Code Review)