Change in coreboot[master]: mb/google/dedede: add lalala variant - coreboot-gerrit

1 Apr 2021


      Attention is currently required from: Martin Roth, Paul Menzel, Aseda Aboagye, Aaron Durbin.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52031 )
Change subject: mb/google/dedede: add lalala variant
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/mainboard/google/dedede/variants/lalala/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52031/comment/f901d6ef_93dd7c0e 
PS2, Line 301: 			chip drivers/wifi/generic
             : 				register "wake" = "GPE0_DW2_03"
             : 				device pci 00.0 on  end
             : 			end
Is it using Discrete WiFi? If not, this can be removed.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52031
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f7abb9637cd5a13ac896396781b19feb156c948
Gerrit-Change-Number: 52031
Gerrit-PatchSet: 2
Gerrit-Owner: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Aseda Aboagye aaboagye@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Aseda Aboagye aaboagye@google.com
Gerrit-Attention: Aaron Durbin adurbin@chromium.org
Gerrit-Comment-Date: Thu, 01 Apr 2021 20:01:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment