Change in coreboot[master]: 3rdparty/amd_blobs: update submodule pointer

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Matt Papageorge (Code Review)

16 Sep 2020 16 Sep '20

1:25 p.m.

Matt Papageorge has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45455 )

Change subject: 3rdparty/amd_blobs: update submodule pointer ......................................................................

3rdparty/amd_blobs: update submodule pointer

Change-Id: I1e317cf6ef4803577e9b353fb3313d001db228d7 Signed-off-by: Matt Papageorge matthewpapa07@gmail.com --- M 3rdparty/amd_blobs 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/45455/1

diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs index 3bd9078..e393a88 160000 --- a/3rdparty/amd_blobs +++ b/3rdparty/amd_blobs @@ -1 +1 @@ -Subproject commit 3bd9078d27b10ea732a31bfabe48fa9868379850 +Subproject commit e393a885c89f8ee3f05242a9e42578c60931b49d

Attachments:

attachment.htm (text/html — 2.1 KB)

Show replies by date

Furquan Shaikh (Code Review)

16 Sep 16 Sep

2:54 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45455 )

Change subject: 3rdparty/amd_blobs: update submodule pointer ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e317cf6ef4803577e9b353fb3313d001db228d7 Gerrit-Change-Number: 45455 Gerrit-PatchSet: 1 Gerrit-Owner: Matt Papageorge matthewpapa07@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 16 Sep 2020 17:54:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

3:43 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45455 )

Change subject: 3rdparty/amd_blobs: update submodule pointer ......................................................................

Patch Set 1:

Suggested commit message:

Update amd_blobs submodule to upstream master

Updating from commit id 3bd9078: 2020-08-12 17:03:38 -0600 - (picasso: Update PSP to 0.8.6.7B)

to commit id e393a88: 2020-09-16 14:32:50 +0000 - (Update SMU firmware for Picasso, Pollock and Dali)

This brings in 1 new commits.

This was generated by util/scripts/update_submodules. I did have to modify the minimum number of changes in the script to 1. I'll look at making that an argument instead of having it hardcoded.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e317cf6ef4803577e9b353fb3313d001db228d7 Gerrit-Change-Number: 45455 Gerrit-PatchSet: 1 Gerrit-Owner: Matt Papageorge matthewpapa07@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 16 Sep 2020 18:43:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Matt Papageorge (Code Review)

4:21 p.m.

New subject: Change in coreboot[master]: Update amd_blobs submodule to upstream master

Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Marshall Dawson, Paul Menzel, Nikolai Vyssotski, Aaron Durbin, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45455

to look at the new patch set (#2).

Change subject: Update amd_blobs submodule to upstream master ......................................................................

Update amd_blobs submodule to upstream master

Updating from commit id 3bd9078: 2020-08-12 17:03:38 -0600 - (picasso: Update PSP to 0.8.6.7B)

to commit id e393a88: 2020-09-16 14:32:50 +0000 - (Update SMU firmware for Picasso, Pollock and Dali)

This brings in 1 new commits.

Change-Id: I1e317cf6ef4803577e9b353fb3313d001db228d7 Signed-off-by: Matt Papageorge matthewpapa07@gmail.com --- M 3rdparty/amd_blobs 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/45455/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e317cf6ef4803577e9b353fb3313d001db228d7 Gerrit-Change-Number: 45455 Gerrit-PatchSet: 2 Gerrit-Owner: Matt Papageorge matthewpapa07@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Matt Papageorge (Code Review)

4:21 p.m.

New subject: Change in coreboot[master]: Update amd_blobs submodule to upstream master

Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45455 )

Change subject: Update amd_blobs submodule to upstream master ......................................................................

Patch Set 2:

...

Patch Set 1:

Suggested commit message:
Update amd_blobs submodule to upstream master

Updating from commit id 3bd9078:
2020-08-12 17:03:38 -0600 - (picasso: Update PSP to 0.8.6.7B)

to commit id e393a88:
2020-09-16 14:32:50 +0000 - (Update SMU firmware for Picasso, Pollock and Dali)

This brings in 1 new commits.
This was generated by util/scripts/update_submodules. I did have to modify the minimum number of changes in the script to 1. I'll look at making that an argument instead of having it hardcoded.

Sounds good to me, I did not even know that script existed. Will definitely consider using it next time

-- To view, visit https://review.coreboot.org/c/coreboot/+/45455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e317cf6ef4803577e9b353fb3313d001db228d7 Gerrit-Change-Number: 45455 Gerrit-PatchSet: 2 Gerrit-Owner: Matt Papageorge matthewpapa07@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 16 Sep 2020 19:21:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Marshall Dawson (Code Review)

5:35 p.m.

New subject: Change in coreboot[master]: Update amd_blobs submodule to upstream master

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45455 )

Change subject: Update amd_blobs submodule to upstream master ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e317cf6ef4803577e9b353fb3313d001db228d7 Gerrit-Change-Number: 45455 Gerrit-PatchSet: 2 Gerrit-Owner: Matt Papageorge matthewpapa07@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 16 Sep 2020 20:35:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

17 Sep 17 Sep

4:46 p.m.

New subject: Change in coreboot[master]: Update amd_blobs submodule to upstream master

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45455 )

Change subject: Update amd_blobs submodule to upstream master ......................................................................

Update amd_blobs submodule to upstream master

Updating from commit id 3bd9078: 2020-08-12 17:03:38 -0600 - (picasso: Update PSP to 0.8.6.7B)

to commit id e393a88: 2020-09-16 14:32:50 +0000 - (Update SMU firmware for Picasso, Pollock and Dali)

This brings in 1 new commits.

Change-Id: I1e317cf6ef4803577e9b353fb3313d001db228d7 Signed-off-by: Matt Papageorge matthewpapa07@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45455 Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M 3rdparty/amd_blobs 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Marshall Dawson: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/45455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e317cf6ef4803577e9b353fb3313d001db228d7 Gerrit-Change-Number: 45455 Gerrit-PatchSet: 3 Gerrit-Owner: Matt Papageorge matthewpapa07@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

6:37 p.m.

New subject: Change in coreboot[master]: Update amd_blobs submodule to upstream master

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45455 )

Change subject: Update amd_blobs submodule to upstream master ......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19779 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19778 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/19777 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19776 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/19775 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19783 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19782 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19781 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19780

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/45455 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e317cf6ef4803577e9b353fb3313d001db228d7 Gerrit-Change-Number: 45455 Gerrit-PatchSet: 3 Gerrit-Owner: Matt Papageorge matthewpapa07@gmail.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Thu, 17 Sep 2020 21:37:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1678

days inactive

1679

days old

coreboot-gerrit@coreboot.org

7 comments

6 participants

tags (0)

participants (6)

9elements QA (Code Review)
Felix Held (Code Review)
Furquan Shaikh (Code Review)
Marshall Dawson (Code Review)
Martin Roth (Code Review)
Matt Papageorge (Code Review)