Attention is currently required from: Furquan Shaikh, Derek Huang, Brandon Breitenstein, Curtis Chen.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57138 )
Change subject: src/ec/google/chromeec: Add and modify APIs for USB-C DP ALT mode
......................................................................
Patch Set 7:
(3 comments)
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/57138/comment/564da872_df5269a4
PS5, Line 1513: TYPEC_CONTROL_COMMAND_ENTER_MODE
I didn't get it. I didn't add anything in ec_commanfs. […]
Oops I looked at an old rev sorry.
https://review.coreboot.org/c/coreboot/+/57138/comment/9c38a50e_affccb75
PS5, Line 1567: -1 means check all port
Done
Done
https://review.coreboot.org/c/coreboot/+/57138/comment/cbbc657c_10a26b98
PS5, Line 1592: >= 0
done
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57138
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id11510c1ff58579ae2cddfe5a4d69646fd84f5c3
Gerrit-Change-Number: 57138
Gerrit-PatchSet: 7
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Attention: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 03 Sep 2021 19:27:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-MessageType: comment