Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57337 )
Change subject: arch/x86: Update debug message to callout the reason for failure ......................................................................
arch/x86: Update debug message to callout the reason for failure
This patch updates debug message to specifically the case when SMBIOS table 7 write would abort due to either `unknown` CPU or CPU `doesn't have support for deterministic cache cpuid leaf`.
Change-Id: I288593b3f78ab858bf66c689e7cfb6ba2ff746d0 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/57337 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/arch/x86/smbios.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index 71b6a22..f09b2d6 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -767,7 +767,8 @@
enum cpu_type dcache_cpuid = cpu_check_deterministic_cache_cpuid_supported(); if (dcache_cpuid == CPUID_TYPE_INVALID || dcache_cpuid == CPUID_COMMAND_UNSUPPORTED) { - printk(BIOS_DEBUG, "SMBIOS: Unknown CPU\n"); + printk(BIOS_DEBUG, "SMBIOS: Unknown CPU or CPU doesn't support Deterministic " + "Cache CPUID leaf\n"); return len; }