Attention is currently required from: Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Stefan Reinauer, ron minnich, Tim Chu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51824 )
Change subject: Documentation/mb/ocp: Update Delta Lake documentation
......................................................................
Patch Set 5:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51824/comment/8942138e_18db2874
PS5, Line 10: OSF (Open System Firmware) solution.
I have no idea, what the second part means. Is “parity of OSF solution” a separate item?
Patchset:
PS5:
These are great news!
File Documentation/mainboard/ocp/deltalake.md:
https://review.coreboot.org/c/coreboot/+/51824/comment/ce7822cf_04a1dfcc
PS5, Line 31: Intel.
Align below ACM as done above.
https://review.coreboot.org/c/coreboot/+/51824/comment/8ee3f813_df235d2f
PS5, Line 66: mapped to verbose, 0 to 4 and 9 would be mapped to quiet.
Use two spaces?
https://review.coreboot.org/c/coreboot/+/51824/comment/3637c132_c86d56cc
PS5, Line 103: - KM/BPM signing
Don’t use tabs for consistency?
https://review.coreboot.org/c/coreboot/+/51824/comment/b489051b_5fa12c03
PS5, Line 152: - ProcHot
I have no idea, what that means.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51824
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd6ab251cd7806cf8cd3f984ad88c091f85035cf
Gerrit-Change-Number: 51824
Gerrit-PatchSet: 5
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 02 Apr 2021 07:51:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment