Attention is currently required from: Tarun Tuli, Kapil Porwal, Paul Menzel, Maximilian Brune, Angel Pons.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71664 )
Change subject: src/soc/intel: Document meaning of variables
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/71664/comment/7edae43d_2d4b1756
PS1, Line 156: DDI_ENABLE_HPD = 1 << 1, // Hot Plug Detect
I know but there is still no reason to make a multi-line comment for a single line.
This is what i can find in coreboot coding standard wiki
`coreboot style for comments is the C89 "/* ... */" style. You may use C99-style "// ..." comments.`
hence, mentioned as `nit`
I do prefer /* .. */ for single line commenting as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71664
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf88f34cedd09e2461bb05050392e178ec84d5d0
Gerrit-Change-Number: 71664
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 12 Apr 2023 15:04:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment