Attention is currently required from: Jason Nien, EricKY Cheng, Matt DeVillier, Paul Menzel, Eric Lai, Martin Roth, Eric Peers, LeilaCY Lin, Jason Glenesk, Caveh Jalali, Tim Wawrzynczak, Fred Reitberger, Karthikeyan Ramasubramanian, Boris Mittelberg, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68471 )
Change subject: soc/amd/common/acpi: Implement DTTS Proposal
......................................................................
Patch Set 73: Code-Review+2
(5 comments)
File src/soc/amd/common/acpi/DTTS.asl:
https://review.coreboot.org/c/coreboot/+/68471/comment/de51645d_68cc636e
PS42, Line 42: 123
Hi Raul, […]
Done
File src/soc/amd/common/acpi/dptc.asl:
https://review.coreboot.org/c/coreboot/+/68471/comment/470202ac_be2d0c0d
PS71, Line 7: #if CONFIG(FEATURE_DYNAMIC_DPTC)
: #include <soc/amd/common/acpi/dtts.asl>
- In the skyrim/dsdt.asl add the following block: […]
Done
https://review.coreboot.org/c/coreboot/+/68471/comment/8627478f_44234e2d
PS71, Line 10: External(_SB.DTTB, MethodObj)
: External(_SB.DTTC, MethodObj)
: External(_SB.DTTD, MethodObj)
: External(_SB.DTTE, MethodObj)
: External(_SB.DTTF, MethodObj)
- In the skyrim/dsdt.asl add the following block: […]
Done
File src/soc/amd/common/acpi/dptc.asl:
https://review.coreboot.org/c/coreboot/+/68471/comment/eb833b84_5f00a4e5
PS73, Line 34: If (CondRefOf (_SB.DTTS))
: {
Nit:
Could replace this with a #if now:
```
#if CONFIG(FEATURE_DYNAMIC_DPTC)
_SB.DTTS()
Return (Zero)
#endif
``
File src/soc/amd/common/acpi/dtts.asl:
https://review.coreboot.org/c/coreboot/+/68471/comment/010921d3_b5481b03
PS71, Line 28: TIN4 >= 123
I am not sure what is the meaning of below […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I866e5e497e2936984e713029b5f0b6d54cbc9622
Gerrit-Change-Number: 68471
Gerrit-PatchSet: 73
Gerrit-Owner: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: LeilaCY Lin
leilacy_lin@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: LeilaCY Lin
leilacy_lin@compal.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 30 Nov 2022 16:30:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment