Attention is currently required from: Furquan Shaikh, Angel Pons, Subrata Banik, Michael Niewöhner, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50956 )
Change subject: soc/intel/cannonlake: Use common bootblock basecode
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/cannonlake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/50956/comment/29e3da3f_8017028b
PS2, Line 64: /*
: * Clear the GPI interrupt status and enable registers. These
: * registers do not get reset to default state when booting from S5.
: */
: gpi_clear_int_cfg();
Oh, thanks for spotting this oversight. […]
How about bootblock_pch_init() for now, and I'll try to follow up later to move it to common code .
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50956
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3dd647b1c4803de4b36fed51d4f03ef86ff4386
Gerrit-Change-Number: 50956
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 21 Feb 2021 17:34:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment