Attention is currently required from: Furquan Shaikh, Julius Werner.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52011 )
Change subject: coreboot_tables: Print strapping IDs when adding them to coreboot table
......................................................................
Patch Set 1:
(2 comments)
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/52011/comment/9758d8c7_ccc26278
PS1, Line 308: uint64_t fw_config = fw_config_get();
nit: const
https://review.coreboot.org/c/coreboot/+/52011/comment/232f3196_4d062c2b
PS1, Line 321: llx
PRIx64
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52011
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifdbfdd29d25a0937c27113ace776f7aec231a57d
Gerrit-Change-Number: 52011
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 01 Apr 2021 03:34:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment