Attention is currently required from: Furquan Shaikh, Marshall Dawson, Julius Werner, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55856 )
Change subject: commonlib/region: Add support for asynchronous readat ......................................................................
Patch Set 2:
(8 comments)
File src/commonlib/include/commonlib/region.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123290): https://review.coreboot.org/c/coreboot/+/55856/comment/4e0f64e6_35d0de67 PS2, Line 74: cb_err_t rdev_readat_async(const struct region_device *rd, struct rdev_readat_async_context *context, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123290): https://review.coreboot.org/c/coreboot/+/55856/comment/a8ea15a4_249f1375 PS2, Line 97: cb_err_t (*readat_async)(const struct region_device *, struct rdev_readat_async_context *, void *, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123290): https://review.coreboot.org/c/coreboot/+/55856/comment/c76efa65_10eaea8a PS2, Line 97: cb_err_t (*readat_async)(const struct region_device *, struct rdev_readat_async_context *, void *, function definition argument 'const struct region_device *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123290): https://review.coreboot.org/c/coreboot/+/55856/comment/b41e5a6a_9af5cdf2 PS2, Line 97: cb_err_t (*readat_async)(const struct region_device *, struct rdev_readat_async_context *, void *, function definition argument 'struct rdev_readat_async_context *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123290): https://review.coreboot.org/c/coreboot/+/55856/comment/3252af10_9e7a1984 PS2, Line 97: cb_err_t (*readat_async)(const struct region_device *, struct rdev_readat_async_context *, void *, function definition argument 'void *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123290): https://review.coreboot.org/c/coreboot/+/55856/comment/052f5ed8_2f052cfe PS2, Line 97: cb_err_t (*readat_async)(const struct region_device *, struct rdev_readat_async_context *, void *, function definition argument 'size_t' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123290): https://review.coreboot.org/c/coreboot/+/55856/comment/7fe2bf74_7a858e35 PS2, Line 97: cb_err_t (*readat_async)(const struct region_device *, struct rdev_readat_async_context *, void *, function definition argument 'size_t' should also have an identifier name
File src/commonlib/region.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123290): https://review.coreboot.org/c/coreboot/+/55856/comment/30425da7_37ff05cd PS2, Line 136: cb_err_t rdev_readat_async(const struct region_device *rd, struct rdev_readat_async_context *context, line over 96 characters
-
build bot (Jenkins) (Code Review)