Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55263 )
Change subject: ec: Add Star Labs ITE 5570E support ......................................................................
Patch Set 9:
(4 comments)
File src/ec/starlabs/it5570/acpi/ac.asl:
https://review.coreboot.org/c/coreboot/+/55263/comment/7bf790da_3a84dde9 PS4, Line 27: Method (_Q0A, 0, NotSerialized) : { : Notify(BAT0, 0x81) : Notify(ADP1, 0x80) : } : : Method (_Q0B, 0, NotSerialized) : { : Notify(BAT0, 0x81) : Notify(BAT0, 0x80) : }
Yup, you after a comment to say what or just interested?
I'd appreciate if you could add a comment on each, as done for the other queries
File src/ec/starlabs/it5570/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/55263/comment/a244dc1e_c7de15c5 PS4, Line 45: // Store (0x03, _SB.PCI0.GFX0.CLID)
Are you saying that about the `Return (0x0F)`?
No, about the commented-out Store. I wonder what it's supposed to do
File src/ec/starlabs/it5570/acpi/hid.asl:
PS4:
It's different to three others - that's all I know.
Ah, this seems to Intel HID Event Filter stuff.
File src/ec/starlabs/it5570/ec.h:
https://review.coreboot.org/c/coreboot/+/55263/comment/16a08c0b_321ffc2a PS4, Line 14: #define IT5570E_FIXED_ADDR 0x4e
I'm pretty sure it's EC specific, with 89xx and 57xx using 0x4e and 87xx using 0x2e.
I have a board with an IT8987E EC at 0x2e. I guess it doesn't matter for now (can be turned into a Kconfig later on, if need be).
-
Angel Pons (Code Review)