Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Zhuohao Lee.
Ben Chuang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51000 )
Change subject: drivers/genesyslogic/gl9755: Disable the debug mode of short circuit protection
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51000/comment/55444f28_92ce2b5e
PS1, Line 10: debug mode needs to be turned off.
Can you please explain, what the problem is? Is it documented in the datasheet?
When Howard verify the SCP/OCP function of GL9755, he found the function is not working.
We check the default of GL9755 is to enable SCP debug mode.
In this mode, the hardware's SCP or OCP protection will not work.
Patchset:
PS1:
Is this related to a google project? Is there a google bug number?
From Howard information, it is Drobit and there is no a google bug number.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51000
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iacfa3c668a52d1bae15fe82f1c614d0ebd93a957
Gerrit-Change-Number: 51000
Gerrit-PatchSet: 1
Gerrit-Owner: Ben Chuang
benchuanggli@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wayne3 Wang
wayne3_wang@pegatron.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HsuanYang Chen
ynop77@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: 陳建宏
renius.chen@genesyslogic.com.tw
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Fri, 26 Feb 2021 01:51:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ben Chuang
benchuanggli@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment