Attention is currently required from: Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63186 )
Change subject: util/amdfwtool: use ISH support for Sabrina SoC
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/63186/comment/2addd51d_e3d4d24b
PS1, Line 1700: if (needs_ish(soc_id)) {
braces {} are not necessary for single statement blocks
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63186
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e6308854147c9f6f72d722215c833ee86ee4f94
Gerrit-Change-Number: 63186
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 29 Mar 2022 22:20:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment