Attention is currently required from: Nico Huber, Angel Pons, Michael Niewöhner, Werner Zeh. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49542 )
Change subject: [RFC] Documentation/coding_style: Clarify line limit for text blocks ......................................................................
Patch Set 1:
(1 comment)
File Documentation/coding_style.md:
https://review.coreboot.org/c/coreboot/+/49542/comment/eed79d06_eb6cc4e0 PS1, Line 97: the overall line length should not exceed 96 chars.
Not sure if it is written down somewhere. […]
I'm honestly hearing about this for the first time. I don't really feel like getting into this again, but please realize that you're now asking people to keep track of 3 different widths (96 for the whole file, 72 for blocks, and 80 because 95% of our files are still formatted to 80 after... what... two years?... even though the Vote96 election campaign team promised they would totally all get reformatted in quick succession after the switch so our codebase will be consistent again). And I barely see most people following the existing rules already.
At some point, is the extra struggle of reading a 96 character comment block really worth making this even more complicated and confusing? I don't think most editors even have a feature to auto-format something to X characters without counting indentation. Gerrit doesn't have any feature to show it. How are people supposed to follow or enforce this in practice?