Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Patrick Rudolph.
Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/86466?usp=email )
Change subject: soc/amd/cezanne/acpi: Add ACP MSG0 method
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/cezanne/acpi.c:
https://review.coreboot.org/c/coreboot/+/86466/comment/983ad22c_d8fedc54?usp... :
PS3, Line 113: acpigen_write_integer(smn_address);
good catch! my code didn't write the DWORD_PREFIX before the DWORD value which explains the malfunction
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86466?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I34f641fbfe40b5df7f0ff2fc173510c5cf2a7f61
Gerrit-Change-Number: 86466
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 25 Feb 2025 17:09:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No