Attention is currently required from: Furquan Shaikh, Martin Roth, Mariusz Szafrański, Jonathan Zhang, Paul Menzel, Angel Pons.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51180 )
Change subject: util/sconfig: Fix for multidomain support sconfig/devicetree.cb
......................................................................
Patch Set 5:
(1 comment)
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/51180/comment/04ce601a_3e591e73
PS5, Line 1344: extern DEVTREE_CONST struct device *const __pci_%d_%02x_%d
Does this make sense? You'd sort of expect this to be a PCI's BDF but that's not the case with the multidomain approach. Maybe only expose devices when the ptr->parent->dev->path_a == 0?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51180
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd639d0cb3ed1a49ed7c7b1c77ac747ba6f77672
Gerrit-Change-Number: 51180
Gerrit-PatchSet: 5
Gerrit-Owner: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 28 Mar 2022 15:27:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment