Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Matt DeVillier, Nick Vaccaro, Subrata Banik.
John Su has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86338?usp=email )
Change subject: mb/google/trulo/var/uldrenite: Add fw_config probe for USB-C ports
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/uldrenite/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/86338/comment/cfae84bd_f9d63248?usp... :
PS1, Line 12: option MB_C_ONE 1
so this option isn't being used yet?
Plan to use FW_Config to map the corresponding SKU next time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86338?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic0161e8b85c5a2afe6ec8473497d21a5737f4f70
Gerrit-Change-Number: 86338
Gerrit-PatchSet: 1
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Wed, 12 Feb 2025 02:40:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com