Attention is currently required from: Henry Sun, Bob Moragues, Aseda Aboagye.
Sunwei Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56687 )
Change subject: mb/google/dedede/var/cappy2: Disable external bypass VR
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56687/comment/e1e4c974_ef93853d
PS2, Line 7: For anpec apw8738bqbi shortage
nit: A better subject might be "Disable external bypass VR"
Done
https://review.coreboot.org/c/coreboot/+/56687/comment/0d1eccda_00fe4e79
PS2, Line 9: Cappy2 have removed the anpec apw8738bqbi
Can you elaborate about how removing that part corresponds with setting this option?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56687
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb4182a989459db629e3b69757c293ca26e8b0cd
Gerrit-Change-Number: 56687
Gerrit-PatchSet: 4
Gerrit-Owner: Sunwei Li
lisunwei@huaqin.corp-partner.google.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Comment-Date: Fri, 30 Jul 2021 08:57:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aseda Aboagye
aaboagye@google.com
Gerrit-MessageType: comment