Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59360 )
Change subject: soc/intel/alderlake, soc/common: Add method to determine the cpu type mask
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/acpi/cpu_hybrid.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134189):
https://review.coreboot.org/c/coreboot/+/59360/comment/65b0bb2f_cc0e15e5
PS2, Line 29: if (my_apic_id > dev->path.apic.apic_id) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59360
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4ceb24d9bb1e808750bf618c29b2b9ea6d4191b
Gerrit-Change-Number: 59360
Gerrit-PatchSet: 2
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 24 Nov 2021 12:13:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment