Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45384 )
Change subject: volteer: set GSPI CS to deasserted by default
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45384/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45384/1//COMMIT_MSG@9
PS1, Line 9: This sets the state of GSPI chip select to 1 (deasserted). GSPI 0 and
Could you mention this is set by the FSP?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45384
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47aa5db429d75e66095d58a1eb77963dcfc3b9f3
Gerrit-Change-Number: 45384
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Andrey Pronin
apronin@chromium.org
Gerrit-Reviewer: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Sep 2020 16:35:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment