Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45952 )
Change subject: soc/intel/common: add Kconfig to enable/disable the ACPI PM timer
......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45952/17/src/soc/intel/common/block...
File src/soc/intel/common/block/pmc/Kconfig:
https://review.coreboot.org/c/coreboot/+/45952/17/src/soc/intel/common/block...
PS17, Line 45: is required for ACPI
It sounds like, if you disable the timer, then ACPI stop working?
https://review.coreboot.org/c/coreboot/+/45952/17/src/soc/intel/common/block...
PS17, Line 45: TCO
It’d be great, if you spelt it out once.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45952
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f607f277eb14f84a7370ffb25a13226e7ccc917
Gerrit-Change-Number: 45952
Gerrit-PatchSet: 17
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 06 Oct 2020 08:36:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment