Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58644 )
Change subject: amd/sata: Remove the weak function
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58644/comment/409ab0a6_f3d0e646
PS4, Line 8:
Why?
every SoC that selects the Kconfig option which included this file in the build implements this function and if no weak functions are really needed in a place, it's best to get rid of those, since weak functions sometimes hide problems hat would otherwise been build failures which are easier to catch.
might be worth mentioning that in the commit message; i guess that's your call to action there?!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58644
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1908f727a7be1e33cbfd273b7261cbd989a414fe
Gerrit-Change-Number: 58644
Gerrit-PatchSet: 5
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Sat, 30 Oct 2021 19:00:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment