Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39133 )
Change subject: mb/kontron: Add Kontron mAL10 COMe module support
......................................................................
Patch Set 57: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/39133/48/src/mainboard/kontron/mal1...
File src/mainboard/kontron/mal10/Kconfig:
https://review.coreboot.org/c/coreboot/+/39133/48/src/mainboard/kontron/mal1...
PS48, Line 6: HAVE_ACPI_RESUME
Does this even work with the chosen MRC options?
Ack
https://review.coreboot.org/c/coreboot/+/39133/48/src/mainboard/kontron/mal1...
File src/mainboard/kontron/mal10/ramstage.c:
https://review.coreboot.org/c/coreboot/+/39133/48/src/mainboard/kontron/mal1...
PS48, Line 8: /* Configure GPIO */
: size_t num = 0;
: const struct pad_config *gpio_table = get_gpio_table(&num);
: gpio_configure_pads(gpio_table, num);
now inside a function carrier_gpio_configure()
Perfect
https://review.coreboot.org/c/coreboot/+/39133/48/src/mainboard/kontron/mal1...
PS48, Line 31: PkgCStateLimit
added comment here in the patchset:57 […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8432e10396f77eb05a71af1ccaaa4437a2e43ea
Gerrit-Change-Number: 39133
Gerrit-PatchSet: 57
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Nov 2020 22:33:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment