Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45010 )
Change subject: soc/intel/skylake: Fix NHLT_PDM_DEV definition ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45010/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45010/3//COMMIT_MSG@7 PS3, Line 7: Fix NHLT_PDM_DEV definition Sorry, but the change doesn't do this. It sets the correct value for KBL, but does not fix the NHLT_PDM_DEV definition.
I'd add a Kconfig symbol for cAVS1.5 so that only SKL/KBL needs to select it, then adjust the value for NHLT_PDM_DEV accordingly.