Change in coreboot[master]: mb/google/volteer: support variant defined spd paths

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Nick Vaccaro (Code Review)

6 Aug 2020 6 Aug '20

11:30 p.m.

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44274 )

Change subject: mb/google/volteer: support variant defined spd paths ......................................................................

mb/google/volteer: support variant defined spd paths

Allow variants to override the SPD_SOURCE_PATH to allow supporting different types of DDR.

BUG=b:163065661 TEST="emerge-volteer coreboot" and verify all variants build.

Change-Id: Id52e651848548a783d6d9f57e88f6099425b063e Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/spd/Makefile.inc 1 file changed, 5 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/44274/1

diff --git a/src/mainboard/google/volteer/spd/Makefile.inc b/src/mainboard/google/volteer/spd/Makefile.inc index e125994..d0cc720 100644 --- a/src/mainboard/google/volteer/spd/Makefile.inc +++ b/src/mainboard/google/volteer/spd/Makefile.inc @@ -4,7 +4,11 @@ ifneq ($(SPD_SOURCES),) SPD_BIN = $(obj)/spd.bin

-SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/soc/intel/tigerlake/spd/lp4x/$(f)) +ifeq ($(SPD_SOURCE_PATH),) +SPD_SOURCE_PATH := src/soc/intel/tigerlake/spd/lp4x/ +endif + +SPD_DEPS := $(foreach f, $(SPD_SOURCES), $$(SPD_SOURCE_PATH)/$(f))

# Include spd ROM data $(SPD_BIN): $(SPD_DEPS)

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Caveh Jalali (Code Review)

7 Aug 7 Aug

12:48 a.m.

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44274 )

Change subject: mb/google/volteer: support variant defined spd paths ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44274/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/spd/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/44274/1/src/mainboard/google/voltee... PS1, Line 8: / no need for the trailing '/'.

https://review.coreboot.org/c/coreboot/+/44274/1/src/mainboard/google/voltee... PS1, Line 11: $$ you shouldn't need second expansion here.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id52e651848548a783d6d9f57e88f6099425b063e Gerrit-Change-Number: 44274 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mice Lin mice_lin@wistron.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 06 Aug 2020 22:48:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nick Vaccaro (Code Review)

2:28 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44274

to look at the new patch set (#2).

Change subject: mb/google/volteer: support variant defined spd paths ......................................................................

mb/google/volteer: support variant defined spd paths

Allow variants to override the SPD_SOURCE_PATH to allow supporting different types of DDR.

BUG=b:163065661 TEST="emerge-volteer coreboot" and verify all variants build.

Change-Id: Id52e651848548a783d6d9f57e88f6099425b063e Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/spd/Makefile.inc 1 file changed, 5 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/44274/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id52e651848548a783d6d9f57e88f6099425b063e Gerrit-Change-Number: 44274 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mice Lin mice_lin@wistron.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Nick Vaccaro (Code Review)

2:29 a.m.

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44274 )

Change subject: mb/google/volteer: support variant defined spd paths ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44274/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/spd/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/44274/1/src/mainboard/google/voltee... PS1, Line 8: /

...

no need for the trailing '/'.

Done

https://review.coreboot.org/c/coreboot/+/44274/1/src/mainboard/google/voltee... PS1, Line 11: $$

...

you shouldn't need second expansion here.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/44274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id52e651848548a783d6d9f57e88f6099425b063e Gerrit-Change-Number: 44274 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mice Lin mice_lin@wistron.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 07 Aug 2020 00:29:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Caveh Jalali caveh@chromium.org Gerrit-MessageType: comment

Caveh Jalali (Code Review)

3:52 a.m.

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44274 )

Change subject: mb/google/volteer: support variant defined spd paths ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id52e651848548a783d6d9f57e88f6099425b063e Gerrit-Change-Number: 44274 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mice Lin mice_lin@wistron.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 07 Aug 2020 01:52:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nick Vaccaro (Code Review)

8:32 a.m.

Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44274 )

Change subject: mb/google/volteer: support variant defined spd paths ......................................................................

mb/google/volteer: support variant defined spd paths

Allow variants to override the SPD_SOURCE_PATH to allow supporting different types of DDR.

BUG=b:163065661 TEST="emerge-volteer coreboot" and verify all variants build.

Change-Id: Id52e651848548a783d6d9f57e88f6099425b063e Signed-off-by: Nick Vaccaro nvaccaro@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44274 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Caveh Jalali caveh@chromium.org --- M src/mainboard/google/volteer/spd/Makefile.inc 1 file changed, 5 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/spd/Makefile.inc b/src/mainboard/google/volteer/spd/Makefile.inc index e125994..1077a36 100644 --- a/src/mainboard/google/volteer/spd/Makefile.inc +++ b/src/mainboard/google/volteer/spd/Makefile.inc @@ -4,7 +4,11 @@ ifneq ($(SPD_SOURCES),) SPD_BIN = $(obj)/spd.bin

-SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/soc/intel/tigerlake/spd/lp4x/$(f)) +ifeq ($(SPD_SOURCE_PATH),) +SPD_SOURCE_PATH := src/soc/intel/tigerlake/spd/lp4x +endif + +SPD_DEPS := $(foreach f, $(SPD_SOURCES), $(SPD_SOURCE_PATH)/$(f))

# Include spd ROM data $(SPD_BIN): $(SPD_DEPS)

-- To view, visit https://review.coreboot.org/c/coreboot/+/44274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id52e651848548a783d6d9f57e88f6099425b063e Gerrit-Change-Number: 44274 Gerrit-PatchSet: 3 Gerrit-Owner: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mice Lin mice_lin@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

Paul Menzel (Code Review)

9:32 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44274 )

Change subject: mb/google/volteer: support variant defined spd paths ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44274/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44274/2//COMMIT_MSG@7 PS2, Line 7: spd SPD

-- To view, visit https://review.coreboot.org/c/coreboot/+/44274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id52e651848548a783d6d9f57e88f6099425b063e Gerrit-Change-Number: 44274 Gerrit-PatchSet: 3 Gerrit-Owner: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Mice Lin mice_lin@wistron.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 07 Aug 2020 07:32:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1597

days inactive

1598

days old

coreboot-gerrit@coreboot.org

6 comments

3 participants

tags (0)

participants (3)

Caveh Jalali (Code Review)
Nick Vaccaro (Code Review)
Paul Menzel (Code Review)