Change in coreboot[master]: arch/x86/smbios.c: Fix for CONFIG_MAX_CPUS > 255 - coreboot-gerrit

11 Apr 2022


      Attention is currently required from: Angel Pons.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63482 )
Change subject: arch/x86/smbios.c: Fix for CONFIG_MAX_CPUS > 255
......................................................................
Patch Set 4:
(1 comment)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/63482/comment/e69f42a8_e2f6c032 
PS4, Line 575: MAX_CPUS_ENABLED
...
Why not:
MIN(CONFIG_MAX_CPUS, 0xff)
Won't work. Compiler complains about comparing integeres of different sizes.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63482
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I079c99006fea95ba3dc2fb02c95a3747af55e218
Gerrit-Change-Number: 63482
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 11 Apr 2022 10:22:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment