Change in coreboot[master]: crossgcc: Upgrade IASL to version 20200925

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

26 Sep 2020 26 Sep '20

3:27 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

crossgcc: Upgrade IASL to version 20200925

Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200925_iasl.patch D util/crossgcc/sum/acpica-unix2-20200717.tar.gz.cksum 3 files changed, 13 insertions(+), 13 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/45750/1

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 0f9cac5..8865e95 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -40,7 +40,7 @@ GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.35 GDB_VERSION=9.2 -IASL_VERSION=20200717 +IASL_VERSION=20200925 PYTHON_VERSION=3.8.5 EXPAT_VERSION=2.2.9 # CLANG version number diff --git a/util/crossgcc/patches/acpica-unix2-20200717_iasl.patch b/util/crossgcc/patches/acpica-unix2-20200925_iasl.patch similarity index 64% rename from util/crossgcc/patches/acpica-unix2-20200717_iasl.patch rename to util/crossgcc/patches/acpica-unix2-20200925_iasl.patch index 01dec7c..f3339c8 100644 --- a/util/crossgcc/patches/acpica-unix2-20200717_iasl.patch +++ b/util/crossgcc/patches/acpica-unix2-20200925_iasl.patch @@ -1,27 +1,28 @@ -diff -Naur acpica-unix2-20200717_/source/compiler/asloptions.c acpica-unix2-20200717/source/compiler/asloptions.c > acpica-unix2-20200717_iasl.patch ---- acpica-unix2-20200717_/source/compiler/asloptions.c -+++ acpica-unix2-20200717/source/compiler/asloptions.c -@@ -126,6 +126,7 @@ - if (Gbl_DoSignon) +diff --git a/source/compiler/asloptions.c b/source/compiler/asloptions.c +index 4bf9465ba..bcd5abf80 100644 +--- a/source/compiler/asloptions.c ++++ b/source/compiler/asloptions.c +@@ -234,6 +234,7 @@ AslCommandLine ( + if (AslGbl_DoSignon) { printf (ACPI_COMMON_SIGNON (ASL_COMPILER_NAME)); + printf ("%s\n", COREBOOT_TOOLCHAIN_VERSION); if (AslGbl_IgnoreErrors) { printf ("Ignoring all errors, forcing AML file generation\n\n"); -@@ -753,6 +754,7 @@ +@@ -866,6 +867,7 @@ AslDoOptions ( case '^': - + printf (ACPI_COMMON_SIGNON (ASL_COMPILER_NAME)); + printf ("%s\n", COREBOOT_TOOLCHAIN_VERSION); exit (0); - + case 'a': -@@ -766,6 +768,7 @@ - +@@ -879,6 +881,7 @@ AslDoOptions ( + printf (ACPI_COMMON_SIGNON (ASL_COMPILER_NAME)); printf (ACPI_COMMON_BUILD_TIME); + printf ("%s\n", COREBOOT_TOOLCHAIN_VERSION); exit (0); - + case 'e': diff --git a/util/crossgcc/sum/acpica-unix2-20200717.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20200717.tar.gz.cksum deleted file mode 100644 index 9bcfe83..0000000 --- a/util/crossgcc/sum/acpica-unix2-20200717.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -92b0177f36b5209e6a667808ca58ef7462c4a6c7 tarballs/acpica-unix2-20200717.tar.gz

Attachments:

attachment.htm (text/html — 6.1 KB)

Show replies by date

Paul Menzel (Code Review)

26 Sep 26 Sep

9:32 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45750/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45750/1//COMMIT_MSG@8 PS1, Line 8: Do you have a list of boards, where something changed besides the version string?

HAOUAS Elyes (Code Review)

28 Sep 28 Sep

7:48 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45750

to look at the new patch set (#2).

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

crossgcc: Upgrade IASL to version 20200925

"Added support for SMBus predefined names (from SMBus Control Method Interface Specification, Version 1.0, December 10, 1999. New predefined names: _SBA _SBI _SBR _SBT _SBW"

CL:44507 needs current version.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/45750/2

HAOUAS Elyes (Code Review)

7:48 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45750

to look at the new patch set (#3).

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

crossgcc: Upgrade IASL to version 20200925

"Added support for SMBus predefined names (from SMBus Control Method Interface Specification, Version 1.0, December 10, 1999. New predefined names: _SBA _SBI _SBR _SBT _SBW"

https://review.coreboot.org/c/coreboot/+/44507 needs current version.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/45750/3

HAOUAS Elyes (Code Review)

10:43 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45750/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45750/1//COMMIT_MSG@8 PS1, Line 8:

...

Do you have a list of boards, where something changed besides the version string?

you mean BUILD_TIMELESS ? no.

currently the acpica's web site is down. I'll add the change log.

this version is needed for https://review.coreboot.org/c/coreboot/+/44507

HAOUAS Elyes (Code Review)

10:45 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 3: Code-Review-1

I don't know why Jenkins gives +1

the link to download the source code is broken as acpica's web site is down and the link for changelog is missing.

HAOUAS Elyes (Code Review)

2 Oct 2 Oct

3:03 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 3:

looks like they have a serious issue with acpica's web site ...

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Fri, 02 Oct 2020 06:03:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

3:24 p.m.

New subject: Change in coreboot[master]: [build test]crossgcc: Upgrade IASL to version 20200925

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45750

to look at the new patch set (#4).

Change subject: [build test]crossgcc: Upgrade IASL to version 20200925 ......................................................................

[build test]crossgcc: Upgrade IASL to version 20200925

"Added support for SMBus predefined names (from SMBus Control Method Interface Specification, Version 1.0, December 10, 1999. New predefined names: _SBA _SBI _SBR _SBT _SBW"

https://review.coreboot.org/c/coreboot/+/44507 needs SMBus predefined names.

Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc M util/crossgcc/patches/acpica-unix2-20200717_iasl.patch A util/crossgcc/patches/acpica-unix2-upgrade-from-20200717_iasl.patch 3 files changed, 1,286 insertions(+), 15 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/45750/4

Paul Menzel (Code Review)

4:03 p.m.

New subject: Change in coreboot[master]: [build test]crossgcc: Upgrade IASL to version 20200925

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: [build test]crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45750/4/util/crossgcc/patches/acpic... File util/crossgcc/patches/acpica-unix2-20200717_iasl.patch:

https://review.coreboot.org/c/coreboot/+/45750/4/util/crossgcc/patches/acpic... PS4, Line 9: + printf ("%s\n", COREBOOT_TOOLCHAIN_VERSION); The tab looks wrong in this patches, as the surrounding code uses spaces.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Fri, 02 Oct 2020 07:03:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:08 p.m.

New subject: Change in coreboot[master]: [build test]crossgcc: Upgrade IASL to version 20200925

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: [build test]crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45750/4/util/crossgcc/patches/acpic... File util/crossgcc/patches/acpica-unix2-20200717_iasl.patch:

https://review.coreboot.org/c/coreboot/+/45750/4/util/crossgcc/patches/acpic... PS4, Line 9: + printf ("%s\n", COREBOOT_TOOLCHAIN_VERSION);

...

The tab looks wrong in this patches, as the surrounding code uses spaces.

indeed, I didn't used acpica's coding style :))

I'll change that next time.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Fri, 02 Oct 2020 07:08:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

9:52 p.m.

New subject: Change in coreboot[master]: [build test]crossgcc: Upgrade IASL to version 20200925

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45750

to look at the new patch set (#5).

Change subject: [build test]crossgcc: Upgrade IASL to version 20200925 ......................................................................

[build test]crossgcc: Upgrade IASL to version 20200925

"Added support for SMBus predefined names (from SMBus Control Method Interface Specification, Version 1.0, December 10, 1999. New predefined names: _SBA _SBI _SBR _SBT _SBW"

https://review.coreboot.org/c/coreboot/+/44507 and https://review.coreboot.org/c/coreboot/+/41735 needs SMBus predefined names.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/45750/5

HAOUAS Elyes (Code Review)

10:05 p.m.

New subject: Change in coreboot[master]: [build test]crossgcc: Upgrade IASL to version 20200925

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45750

to look at the new patch set (#6).

Change subject: [build test]crossgcc: Upgrade IASL to version 20200925 ......................................................................

[build test]crossgcc: Upgrade IASL to version 20200925

This release sdded support for SMBus predefined names:_SBA, _SBI, _SBR, _SBT and _SBW CB:44507 and CB: 41735 needs this version.

Change log: https://github.com/acpica/acpica/commit/e7f466241113d3a48f18a1ddf0b295565828...

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/45750/6

HAOUAS Elyes (Code Review)

10:06 p.m.

New subject: Change in coreboot[master]: [build test]crossgcc: Upgrade IASL to version 20200925

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45750

to look at the new patch set (#7).

Change subject: [build test]crossgcc: Upgrade IASL to version 20200925 ......................................................................

[build test]crossgcc: Upgrade IASL to version 20200925

This release added support for SMBus predefined names:_SBA, _SBI, _SBR, _SBT and _SBW CB:44507 and CB:41735 needs this version.

Change log: https://github.com/acpica/acpica/commit/e7f466241113d3a48f18a1ddf0b295565828...

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/45750/7

HAOUAS Elyes (Code Review)

10:06 p.m.

New subject: Change in coreboot[master]: [build test]crossgcc: Upgrade IASL to version 20200925

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45750

to look at the new patch set (#8).

Change subject: [build test]crossgcc: Upgrade IASL to version 20200925 ......................................................................

[build test]crossgcc: Upgrade IASL to version 20200925

This release added support for SMBus predefined names:_SBA, _SBI, _SBR, _SBT and _SBW. CB:44507 and CB:41735 needs this version.

Change log: https://github.com/acpica/acpica/commit/e7f466241113d3a48f18a1ddf0b295565828...

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/45750/8

HAOUAS Elyes (Code Review)

3 Oct 3 Oct

4:32 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45750

to look at the new patch set (#9).

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

crossgcc: Upgrade IASL to version 20200925

This release added support for SMBus predefined names:_SBA, _SBI, _SBR, _SBT and _SBW. CB:44507 and CB:41735 needs this version.

As an exception, "acpica-unix2-upgrade-from-20200717_iasl.patch" is added because of a serious issue on acpica's website. acpica's team can not logon to update the latest release archive. So this patch will upgrade the version 20200717 archive.

Change log: https://github.com/acpica/acpica/commit/e7f466241113d3a48f18a1ddf0b295565828...

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/45750/9

HAOUAS Elyes (Code Review)

4:33 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45750

to look at the new patch set (#10).

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

crossgcc: Upgrade IASL to version 20200925

This release added support for SMBus predefined names:_SBA, _SBI, _SBR, _SBT and _SBW. CB:44507 and CB:41735 needs this version.

Change log: https://github.com/acpica/acpica/commit/e7f466241113d3a48f18a1ddf0b295565828...

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/45750/10

HAOUAS Elyes (Code Review)

4:33 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45750/4/util/crossgcc/patches/acpic... File util/crossgcc/patches/acpica-unix2-20200717_iasl.patch:

https://review.coreboot.org/c/coreboot/+/45750/4/util/crossgcc/patches/acpic... PS4, Line 9: + printf ("%s\n", COREBOOT_TOOLCHAIN_VERSION);

...

indeed, I didn't used acpica's coding style :)) […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 10 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Sat, 03 Oct 2020 07:33:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:42 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45750

to look at the new patch set (#11).

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

crossgcc: Upgrade IASL to version 20200925

This release added support for SMBus predefined names:_SBA, _SBI, _SBR, _SBT and _SBW. CB:44507 and CB:41735 needs this version.

Change log: https://github.com/acpica/acpica/commit/e7f466241113d3a48f18a1ddf0b295565828...

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/45750/11

Angel Pons (Code Review)

6:27 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 11:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45750/11//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45750/11//COMMIT_MSG@9 PS11, Line 9: : space after colon

https://review.coreboot.org/c/coreboot/+/45750/11//COMMIT_MSG@9 PS11, Line 9: This release added support for SMBus predefined names:_SBA, _SBI, _SBR, _SBT and _SBW. Please wrap lines at 72 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 11 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Sat, 03 Oct 2020 09:27:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:21 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 11:

(2 comments)

Thx

https://review.coreboot.org/c/coreboot/+/45750/11//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45750/11//COMMIT_MSG@9 PS11, Line 9: This release added support for SMBus predefined names:_SBA, _SBI, _SBR, _SBT and _SBW.

...

Please wrap lines at 72 characters

Done

https://review.coreboot.org/c/coreboot/+/45750/11//COMMIT_MSG@9 PS11, Line 9: :

...

space after colon

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 11 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Sat, 03 Oct 2020 10:21:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:21 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45750

to look at the new patch set (#12).

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

crossgcc: Upgrade IASL to version 20200925

This release added support for SMBus predefined names: _SBA, _SBI, _SBR, _SBT and _SBW.

CB:44507 and CB:41735 needs this version.

Change log: https://github.com/acpica/acpica/commit/e7f466241113d3a48f18a1ddf0b295565828...

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/45750/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 12 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

7 Oct 7 Oct

1:17 a.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 12:

Elyes, that 1200 line patch is a little concerning, but I understand the issue. Are CB:44507 and CB:41735 very urgent? Can they wait to be merged until the ACPICA website is updated?

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 12 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Tue, 06 Oct 2020 16:17:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

1:27 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 12:

...

Patch Set 12:

Elyes, that 1200 line patch is a little concerning, but I understand the issue. Are CB:44507 and CB:41735 very urgent? Can they wait to be merged until the ACPICA website is updated?

indeed, that patch is huge. I think the best solution is to wait... Maxim & Hui, please let us know your thought. Thx

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 12 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Tue, 06 Oct 2020 16:27:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Keith Hui (Code Review)

2:45 a.m.

Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 12:

...

Patch Set 12:

...
Patch Set 12:

Elyes, that 1200 line patch is a little concerning, but I understand the issue. Are CB:44507 and CB:41735 very urgent? Can they wait to be merged until the ACPICA website is updated?

indeed, that patch is huge. I think the best solution is to wait... Maxim & Hui, please let us know your thought. Thx

cb:41735 is for a very "classic" platform of i440BX/PIIX4E. Although the patch is required to enable a pretty basic hardware monitor feature, I'm okay with waiting. It went without that (and quite a few more things) for so long, a little longer won't make it worse.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 12 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Tue, 06 Oct 2020 17:45:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

5:34 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 12: Code-Review-1

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 12 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Tue, 06 Oct 2020 20:34:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Maxim Polyakov (Code Review)

4:21 p.m.

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 12:

...

Patch Set 12:

...
Patch Set 12:

Elyes, that 1200 line patch is a little concerning, but I understand the issue. Are CB:44507 and CB:41735 very urgent? Can they wait to be merged until the ACPICA website is updated?

indeed, that patch is huge. I think the best solution is to wait... Maxim & Hui, please let us know your thought. Thx

Oh sure, let's wait. I have to make some fixes in my ACPI patch, anyway

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 12 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 07 Oct 2020 07:21:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:43 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45750

to look at the new patch set (#13).

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

crossgcc: Upgrade IASL to version 20200925

This release added support for SMBus predefined names: _SBA, _SBI, _SBR, _SBT and _SBW.

CB:44507 and CB:41735 needs this version.

Change log: https://github.com/acpica/acpica/commit/e7f466241113d3a48f18a1ddf0b295565828...

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/45750/13

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 13 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

9 Oct 9 Oct

3:01 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45750

to look at the new patch set (#14).

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

crossgcc: Upgrade IASL to version 20200925

This release added support for SMBus predefined names: _SBA, _SBI, _SBR, _SBT and _SBW.

CB:44507 and CB:41735 needs this version.

Change log: https://acpica.org/node/184

Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200925_iasl.patch A util/crossgcc/sum/acpica-unix2-20200925.tar.gz.cksum 3 files changed, 14 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/45750/14

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 14 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Stefan Reinauer (Code Review)

3 Nov 3 Nov

12:07 p.m.

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 14: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 14 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Tue, 03 Nov 2020 03:07:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Maxim Polyakov (Code Review)

19 Nov 19 Nov

8:16 a.m.

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 14: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 14 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 18 Nov 2020 23:16:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Maxim Polyakov (Code Review)

8:17 a.m.

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

Patch Set 14:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45750/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45750/1//COMMIT_MSG@8 PS1, Line 8:

...

you mean BUILD_TIMELESS ? no. […]

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 14 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 18 Nov 2020 23:17:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Patrick Georgi (Code Review)

23 Nov 23 Nov

7:28 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45750 )

Change subject: crossgcc: Upgrade IASL to version 20200925 ......................................................................

crossgcc: Upgrade IASL to version 20200925

This release added support for SMBus predefined names: _SBA, _SBI, _SBR, _SBT and _SBW.

CB:44507 and CB:41735 needs this version.

Change log: https://acpica.org/node/184

Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/45750 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-by: Maxim Polyakov max.senia.poliak@gmail.com --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200925_iasl.patch A util/crossgcc/sum/acpica-unix2-20200925.tar.gz.cksum 3 files changed, 14 insertions(+), 12 deletions(-)

Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Maxim Polyakov: Looks good to me, approved

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index d5cca6c..375e49d 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -40,7 +40,7 @@ GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.35 GDB_VERSION=9.2 -IASL_VERSION=20200717 +IASL_VERSION=20200925 PYTHON_VERSION=3.8.5 EXPAT_VERSION=2.2.9 # CLANG version number diff --git a/util/crossgcc/patches/acpica-unix2-20200717_iasl.patch b/util/crossgcc/patches/acpica-unix2-20200925_iasl.patch similarity index 64% rename from util/crossgcc/patches/acpica-unix2-20200717_iasl.patch rename to util/crossgcc/patches/acpica-unix2-20200925_iasl.patch index 01dec7c..55adb83 100644 --- a/util/crossgcc/patches/acpica-unix2-20200717_iasl.patch +++ b/util/crossgcc/patches/acpica-unix2-20200925_iasl.patch @@ -1,27 +1,28 @@ -diff -Naur acpica-unix2-20200717_/source/compiler/asloptions.c acpica-unix2-20200717/source/compiler/asloptions.c > acpica-unix2-20200717_iasl.patch ---- acpica-unix2-20200717_/source/compiler/asloptions.c -+++ acpica-unix2-20200717/source/compiler/asloptions.c -@@ -126,6 +126,7 @@ - if (Gbl_DoSignon) +diff --git a/source/compiler/asloptions.c b/source/compiler/asloptions.c +index 4bf9465ba..14c61a122 100644 +--- a/source/compiler/asloptions.c ++++ b/source/compiler/asloptions.c +@@ -234,6 +234,7 @@ AslCommandLine ( + if (AslGbl_DoSignon) { printf (ACPI_COMMON_SIGNON (ASL_COMPILER_NAME)); + printf ("%s\n", COREBOOT_TOOLCHAIN_VERSION); if (AslGbl_IgnoreErrors) { printf ("Ignoring all errors, forcing AML file generation\n\n"); -@@ -753,6 +754,7 @@ +@@ -866,6 +867,7 @@ AslDoOptions ( case '^': - + printf (ACPI_COMMON_SIGNON (ASL_COMPILER_NAME)); + printf ("%s\n", COREBOOT_TOOLCHAIN_VERSION); exit (0); - + case 'a': -@@ -766,6 +768,7 @@ - +@@ -879,6 +881,7 @@ AslDoOptions ( + printf (ACPI_COMMON_SIGNON (ASL_COMPILER_NAME)); printf (ACPI_COMMON_BUILD_TIME); + printf ("%s\n", COREBOOT_TOOLCHAIN_VERSION); exit (0); - + case 'e': diff --git a/util/crossgcc/sum/acpica-unix2-20200925.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20200925.tar.gz.cksum new file mode 100644 index 0000000..fe1665e --- /dev/null +++ b/util/crossgcc/sum/acpica-unix2-20200925.tar.gz.cksum @@ -0,0 +1 @@ +3d5fd9725e0229eb009685f4d356ffda488edc02 tarballs/acpica-unix2-20200925.tar.gz

-- To view, visit https://review.coreboot.org/c/coreboot/+/45750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3559e5bd884db4dccdaa5ac7edba4faf57da7930 Gerrit-Change-Number: 45750 Gerrit-PatchSet: 15 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Keith Hui buurin@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: merged

1415

days inactive

1472

days old

coreboot-gerrit@coreboot.org

31 comments

8 participants

tags (0)

participants (8)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Keith Hui (Code Review)
Maxim Polyakov (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Stefan Reinauer (Code Review)
Tim Wawrzynczak (Code Review)