Attention is currently required from: Lance Zhao, Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson, Maulik V Vaghela, Sugnan Prabhu S, Tim Wawrzynczak, Sridhar Siricilla, Rob Barnes, Patrick Rudolph.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59125 )
Change subject: acpi/acpigen,soc/amd,cpu/inte: Refactor the code
......................................................................
Patch Set 1:
(1 comment)
File src/acpi/acpigen.c:
https://review.coreboot.org/c/coreboot/+/59125/comment/346d2174_f14db5fc
PS1, Line 1808: __weak void acpigen_write_CPPC_method(int core_id)
i'm not exactly sure what the goal of this change will be, but i'd avoid using weak functions if possible, since having weak functions where it would be avoidable might hide bugs like this one CB:58662
if there's some functionality needed to generate sufficiently different acpi code for a similar purpose, i'd either create another function for that or maybe add some sort of parameter to enable the generation of the additional acpi code
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59125
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bdcf94973973dcf7b1ff915df6e23108c9b8ff9
Gerrit-Change-Number: 59125
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 12 Nov 2021 00:09:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment