Change in coreboot[master]: [WIP] mb/google/guybrush: add DXIO and DDI descriptors - coreboot-gerrit

1 Apr 2021


      Attention is currently required from: Marshall Dawson, Matt Papageorge, Felix Held.
Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51957 )
Change subject: [WIP] mb/google/guybrush: add DXIO and DDI descriptors
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/guybrush/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/51957/comment/80410349_29776b11 
PS3, Line 55: DDI_DP
...
oh, i meant https://review.coreboot.org/c/coreboot/+/51948/1/src/soc/amd/cezanne/fsp_m_p.... […]
Ok, but my previous comment still stands. I don't think this was right for Guybrush
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51957
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8a4349315f8759c79dc6b087b2a933c307cd573
Gerrit-Change-Number: 51957
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Matt Papageorge matthewpapa07@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-CC: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Matt Papageorge matthewpapa07@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 01 Apr 2021 20:04:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment