Attention is currently required from: Jason Nien, Martin Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73294 )
Change subject: mb/google/skyrim: Allow port descriptors to be overridden
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/skyrim/port_descriptors.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171145):
https://review.coreboot.org/c/coreboot/+/73294/comment/75148603_1c324adb
PS1, Line 97: if (!*dxio_num || !*dxio_descs)
that open brace { should be on the previous line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8cff44f5b39d130a7191a69970cae8a88bb5d475
Gerrit-Change-Number: 73294
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Mon, 27 Feb 2023 17:54:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment