Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/28730 )
Change subject: siemens/mc_apl1: Make the DDR memory swizzle data configurable
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28730/1/src/mainboard/siemens/mc_apl1/romsta...
File src/mainboard/siemens/mc_apl1/romstage.c:
https://review.coreboot.org/#/c/28730/1/src/mainboard/siemens/mc_apl1/romsta...
PS1, Line 80: sz
You could just have used (size_t)DQ_BITS_PER_DQS here directly as you have to break the line anyway […]
Done
--
To view, visit
https://review.coreboot.org/28730
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4954d0a00d1d5fc28a8dda45a9fb27f98d5c3f1e
Gerrit-Change-Number: 28730
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 26 Sep 2018 13:06:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No