Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33759 )
Change subject: soc/amd/picasso: Add ability to begin romstage in DRAM ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33759/4/src/soc/amd/picasso/reset_v... File src/soc/amd/picasso/reset_vector.S:
https://review.coreboot.org/c/coreboot/+/33759/4/src/soc/amd/picasso/reset_v... PS4, Line 135: */ No such file? Why near stacktop when you have .bss?
https://review.coreboot.org/c/coreboot/+/33759/4/src/soc/amd/picasso/reset_v... PS4, Line 142: sub $8, %esp Looks strange, %esp gets aligned again before next call.
https://review.coreboot.org/c/coreboot/+/33759/4/src/soc/amd/picasso/reset_v... PS4, Line 144: jmp _romstage_in_ram_continue You could possibly call car_stage_entry here with timestamp and bist as parameters.
https://review.coreboot.org/c/coreboot/+/33759/4/src/soc/amd/picasso/reset_v... PS4, Line 149: _start: Changing semantics of _start? Used to be protected mode, now realmode, and I don't see what it is used for.
-
Kyösti Mälkki (Code Review)