Attention is currently required from: Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59563 )
Change subject: mb/google/brya/variants/primus: update gpios for power consumption ......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/google/brya/variants/primus/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134089): https://review.coreboot.org/c/coreboot/+/59563/comment/fdc920f9_eca43ac8 PS2, Line 48: int sku = gpio_get(GPP_T2); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134089): https://review.coreboot.org/c/coreboot/+/59563/comment/1af67a41_9b5a28e3 PS2, Line 50: if ( sku == 1 ) space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134089): https://review.coreboot.org/c/coreboot/+/59563/comment/5386c716_850fe3b1 PS2, Line 50: if ( sku == 1 ) space prohibited before that close parenthesis ')'