Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel, Angel Pons, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62933 )
Change subject: soc/mediatek: Ensure PERST# deassertion time follows the spec
......................................................................
Patch Set 14:
(2 comments)
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/62933/comment/0d537934_c8547393
PS14, Line 252: pre-initialize is not found, assert PERST# and sleep 100ms to met the delay requirement
early init data not found; sleeping 100ms
https://review.coreboot.org/c/coreboot/+/62933/comment/7343e776_e481fae8
PS14, Line 257: PERST# assert time %lld us is not enough for link up, sleep %lld us to met the 100ms delay requirement
Need an extra %lld us delay to meet PERST# deassertion requirement
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62933
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie2b7b6174abdf951af5796ab5ed141c45f32fc71
Gerrit-Change-Number: 62933
Gerrit-PatchSet: 14
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Comment-Date: Tue, 29 Mar 2022 02:35:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment